Re: [PATCH 1/3] mxl692: MaxLinear 692 ATSC demod-tuner driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3359 bytes --]

Hi Brad,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.7 next-20200613]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Brad-Love/MaxLinear-mxl692-demod-tuner-Hauppauge-usb-QuadHD/20200613-024056
base:   git://linuxtv.org/media_tree.git master
config: alpha-randconfig-c021-20200612 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/media/dvb-frontends/mxl692.c: In function 'mxl692_read_ber_ucb':
>> drivers/media/dvb-frontends/mxl692.c:1159:47: warning: variable 'qam_errors' set but not used [-Wunused-but-set-variable]
1159 |  struct MXL_EAGLE_QAM_DEMOD_ERROR_COUNTERS_T *qam_errors;
|                                               ^~~~~~~~~~

vim +/qam_errors +1159 drivers/media/dvb-frontends/mxl692.c

  1153	
  1154	static int mxl692_read_ber_ucb(struct dvb_frontend *fe)
  1155	{
  1156		struct mxl692_dev *dev = fe->demodulator_priv;
  1157		struct dtv_frontend_properties *c = &fe->dtv_property_cache;
  1158		u8 rx_buf[MXL_EAGLE_MAX_I2C_PACKET_SIZE] = {};
> 1159		struct MXL_EAGLE_QAM_DEMOD_ERROR_COUNTERS_T *qam_errors;
  1160		struct MXL_EAGLE_ATSC_DEMOD_ERROR_COUNTERS_T *atsc_errors;
  1161		enum MXL_EAGLE_DEMOD_TYPE_E demod_type = dev->demod_type;
  1162		int mxl_status = 0;
  1163		u32 utmp;
  1164	
  1165		dev_dbg(&dev->i2c_client->dev, "\n");
  1166	
  1167		qam_errors = (struct MXL_EAGLE_QAM_DEMOD_ERROR_COUNTERS_T *)&rx_buf;
  1168		atsc_errors = (struct MXL_EAGLE_ATSC_DEMOD_ERROR_COUNTERS_T *)&rx_buf;
  1169	
  1170		switch (demod_type) {
  1171		case MXL_EAGLE_DEMOD_TYPE_ATSC:
  1172			mxl_status = mxl692_i2c_writeread(dev,
  1173							  MXL_EAGLE_OPCODE_ATSC_ERROR_COUNTERS_GET,
  1174							  NULL,
  1175							  0,
  1176							  rx_buf,
  1177							  sizeof(struct MXL_EAGLE_ATSC_DEMOD_ERROR_COUNTERS_T));
  1178			if (!mxl_status) {
  1179				if (atsc_errors->error_packets == 0)
  1180					utmp = 0;
  1181				else
  1182					utmp = ((atsc_errors->error_bytes / atsc_errors->error_packets) *
  1183						atsc_errors->total_packets);
  1184				/* ber */
  1185				c->post_bit_error.stat[0].scale = FE_SCALE_COUNTER;
  1186				c->post_bit_error.stat[0].uvalue += atsc_errors->error_bytes;
  1187				c->post_bit_count.stat[0].scale = FE_SCALE_COUNTER;
  1188				c->post_bit_count.stat[0].uvalue += utmp;
  1189				/* ucb */
  1190				c->block_error.stat[0].scale = FE_SCALE_COUNTER;
  1191				c->block_error.stat[0].uvalue += atsc_errors->error_packets;
  1192	
  1193				dev_dbg(&dev->i2c_client->dev, "%llu   %llu\n",
  1194					c->post_bit_count.stat[0].uvalue, c->block_error.stat[0].uvalue);
  1195			}
  1196			break;
  1197		case MXL_EAGLE_DEMOD_TYPE_QAM:
  1198		case MXL_EAGLE_DEMOD_TYPE_OOB:
  1199		default:
  1200			break;
  1201		}
  1202		return 0;
  1203	}
  1204	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33557 bytes --]