From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>,
Brad Love <brad@nextdimension.cc>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kernel@vger.kernel.org, Sean Young <sean@mess.org>,
devel@driverdev.osuosl.org,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [RFC 0/4] Don't do tuning zigzag using the very same frequency
Date: Wed, 17 Jun 2020 21:07:55 +0200 [thread overview]
Message-ID: <20200617210755.1138caa2@coco.lan> (raw)
In-Reply-To: <cover.1592419750.git.mchehab+huawei@kernel.org>
Em Wed, 17 Jun 2020 20:52:10 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> escreveu:
> Marc reported on IRC that the zigzag code is trying to tune several times using
> the same frequency with si2168. Well, this is not how this would be supposed
> to do: it should try with different frequencies each time.
>
> Change the core to use the one-shot mode if the frontend doesn't report a
> frequency step. This will default to the current behavior, except that tuning
> should be faster.
>
> Yet, probably the right thing to do is to implement a frequency shift at such
> frontends, as otherwise tuning may have problems. So, produce a warning
> on such cases, in order for the FE driver to be fixed.
>
> Mauro Carvalho Chehab (4):
> media: atomisp: fix identation at I2C Kconfig menu
> media: atomisp: fix help message for ISP2401 selection
Those two patches are unrelated. Please ignore it on the context of this RFC.
Thanks,
Mauro
prev parent reply other threads:[~2020-06-17 19:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 18:52 [RFC 0/4] Don't do tuning zigzag using the very same frequency Mauro Carvalho Chehab
2020-06-17 18:52 ` [RFC 1/4] media: atomisp: fix identation at I2C Kconfig menu Mauro Carvalho Chehab
2020-06-17 18:52 ` [RFC 2/4] media: atomisp: fix help message for ISP2401 selection Mauro Carvalho Chehab
2020-06-17 18:52 ` [RFC 3/4] media: dvb_frontend: move algo-specific settings to a function Mauro Carvalho Chehab
2020-06-18 9:20 ` Marc Gonzalez
2020-06-17 18:52 ` [RFC 4/4] media: dvb_frontend: disable zigzag mode if not possible Mauro Carvalho Chehab
2020-06-18 9:50 ` Marc Gonzalez
2021-03-22 15:33 ` Mauro Carvalho Chehab
2021-03-22 15:33 ` [PATCH] media: dvb_frontend: warn if frontend driver has API issues Mauro Carvalho Chehab
2020-06-17 19:07 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617210755.1138caa2@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=arnd@arndb.de \
--cc=brad@nextdimension.cc \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=masahiroy@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).