From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74FBCC433DF for ; Sun, 19 Jul 2020 06:11:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 550452073A for ; Sun, 19 Jul 2020 06:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595139062; bh=v+tBQTFsBwAbo1jkBKxGAaOodtQy54tKEIs8raoBUpo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=fTy42MzO32vSfB8frOohHEd8MJyyLP/D5+3SYSe7wUMdAhOZgborPKE2Ln52r+mOy IQoIiTsAblBZH8yIJRDw7YUb4UTIQwNSp1MA9iguGKerYNMgvos88lk1YI+7o2NHxB cp6A5sVNeu62dvoHZ30+BY1XRMnIuLWnUQp6Z2vk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726428AbgGSGK6 (ORCPT ); Sun, 19 Jul 2020 02:10:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:50670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgGSGK6 (ORCPT ); Sun, 19 Jul 2020 02:10:58 -0400 Received: from coco.lan (ip5f5ad5c5.dynamic.kabel-deutschland.de [95.90.213.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BEAEF2073A; Sun, 19 Jul 2020 06:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595139058; bh=v+tBQTFsBwAbo1jkBKxGAaOodtQy54tKEIs8raoBUpo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IKwz6zoityKzRAm8cn5VH9j055zpzXNgsntvnyoyaojNiWglYYi4npceclHpdQufy e9kDiL99STu2HoX0jJg3PT8d9jrSO7EV9p15kh5wzx1DKGo84iK0eFKQozqgCG4n+u PDn/e1wYyoMDWeBFXHFvuzKKj90H2b52KXKVkn0A= Date: Sun, 19 Jul 2020 08:10:54 +0200 From: Mauro Carvalho Chehab To: B K Karthik Cc: Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: media: atomisp: pci: css_2401_system: host: csi_rx.c: fixed a sparse warning by making undeclared symbols static Message-ID: <20200719081054.7915a8ae@coco.lan> In-Reply-To: <20200714132350.naekk4zqivpuaedi@pesu-pes-edu> References: <20200714132350.naekk4zqivpuaedi@pesu-pes-edu> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Tue, 14 Jul 2020 09:23:50 -0400 B K Karthik escreveu: > changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES, > N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they > were not declared earlier. This patch is broken: ERROR: modpost: "N_CSI_RX_FE_CTRL_DLANES" [drivers/staging/media/atomisp/atomisp.ko] undefined! ERROR: modpost: "N_LONG_PACKET_LUT_ENTRIES" [drivers/staging/media/atomisp/atomisp.ko] undefined! ERROR: modpost: "N_SHORT_PACKET_LUT_ENTRIES" [drivers/staging/media/atomisp/atomisp.ko] undefined! Please test your patches before submitting them. I suspect that the header declaring them weren't included at csi_rx.c. Regards, Mauro > > Signed-off-by: B K Karthik > --- > .../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c b/drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c > index 8e661091f7d9..4d2076db1240 100644 > --- a/drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c > +++ b/drivers/staging/media/atomisp/pci/css_2401_system/host/csi_rx.c > @@ -15,26 +15,26 @@ > > #include "system_global.h" > > -const u32 N_SHORT_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = { > +static const u32 N_SHORT_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = { > 4, /* 4 entries at CSI_RX_BACKEND0_ID*/ > 4, /* 4 entries at CSI_RX_BACKEND1_ID*/ > 4 /* 4 entries at CSI_RX_BACKEND2_ID*/ > }; > > -const u32 N_LONG_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = { > +static const u32 N_LONG_PACKET_LUT_ENTRIES[N_CSI_RX_BACKEND_ID] = { > 8, /* 8 entries at CSI_RX_BACKEND0_ID*/ > 4, /* 4 entries at CSI_RX_BACKEND1_ID*/ > 4 /* 4 entries at CSI_RX_BACKEND2_ID*/ > }; > > -const u32 N_CSI_RX_FE_CTRL_DLANES[N_CSI_RX_FRONTEND_ID] = { > +static const u32 N_CSI_RX_FE_CTRL_DLANES[N_CSI_RX_FRONTEND_ID] = { > N_CSI_RX_DLANE_ID, /* 4 dlanes for CSI_RX_FR0NTEND0_ID */ > N_CSI_RX_DLANE_ID, /* 4 dlanes for CSI_RX_FR0NTEND1_ID */ > N_CSI_RX_DLANE_ID /* 4 dlanes for CSI_RX_FR0NTEND2_ID */ > }; > > /* sid_width for CSI_RX_BACKEND_ID */ > -const u32 N_CSI_RX_BE_SID_WIDTH[N_CSI_RX_BACKEND_ID] = { > +static const u32 N_CSI_RX_BE_SID_WIDTH[N_CSI_RX_BACKEND_ID] = { > 3, > 2, > 2 Thanks, Mauro