From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2247EC433DF for ; Sun, 19 Jul 2020 13:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B07522C9C for ; Sun, 19 Jul 2020 13:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726093AbgGSNuJ (ORCPT ); Sun, 19 Jul 2020 09:50:09 -0400 Received: from mga01.intel.com ([192.55.52.88]:14088 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbgGSNuJ (ORCPT ); Sun, 19 Jul 2020 09:50:09 -0400 IronPort-SDR: ZUuT4R1DL5wy7Bste3QgUUIff1Q2vsHI09G92+z2ntXYhn2i4gHpdEaWdqjWra2Eo1N7ajT3SP C8BNiGXHTnEw== X-IronPort-AV: E=McAfee;i="6000,8403,9686"; a="167936033" X-IronPort-AV: E=Sophos;i="5.75,370,1589266800"; d="scan'208";a="167936033" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2020 06:50:08 -0700 IronPort-SDR: 2YJuQ/0QKvefYMfDyI9Y6N4/9LyEVGpAFcdg6Z5LPv51p5eSuM2Vq/zuL9N+SXd8DSYBcKNAe9 Y8Nw7DmR1tIw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,370,1589266800"; d="scan'208";a="486963458" Received: from lkp-server02.sh.intel.com (HELO 50058c6ee6fc) ([10.239.97.151]) by fmsmga006.fm.intel.com with ESMTP; 19 Jul 2020 06:50:06 -0700 Received: from kbuild by 50058c6ee6fc with local (Exim 4.92) (envelope-from ) id 1jx9hd-00019d-Ji; Sun, 19 Jul 2020 13:50:05 +0000 Date: Sun, 19 Jul 2020 21:49:07 +0800 From: kernel test robot To: Chuhong Yuan Cc: kbuild-all@lists.01.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab , Hans Verkuil , Kyungmin Park , Sylwester Nawrocki , Kukjin Kim , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH] media: exynos4-is: fix ptr_ret.cocci warnings Message-ID: <20200719134907.GA16381@c288844b3313> References: <202007192158.9kUQhoax%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202007192158.9kUQhoax%lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: kernel test robot drivers/media/platform/exynos4-is/media-dev.c:1273:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 18ffec750578 ("media: exynos4-is: Add missed check for pinctrl_lookup_state()") CC: Chuhong Yuan Signed-off-by: kernel test robot --- tree: git://linuxtv.org/media_tree.git master head: 8f2a4a9d5ff5202d0b3e3a144ebb9b67aabadd29 commit: 18ffec750578f7447c288647d7282c7d12b1d969 [119/306] media: exynos4-is: Add missed check for pinctrl_lookup_state() media-dev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/media/platform/exynos4-is/media-dev.c +++ b/drivers/media/platform/exynos4-is/media-dev.c @@ -1270,10 +1270,7 @@ static int fimc_md_get_pinctrl(struct fi pctl->state_idle = pinctrl_lookup_state(pctl->pinctrl, PINCTRL_STATE_IDLE); - if (IS_ERR(pctl->state_idle)) - return PTR_ERR(pctl->state_idle); - - return 0; + return PTR_ERR_OR_ZERO(pctl->state_idle); } static int cam_clk_prepare(struct clk_hw *hw)