Re: [PATCH] [MEDIA] Use standard integer types

[Sean Young <sean@mess.org>]

On Mon, Jul 20, 2020 at 08:10:18PM +0200, Hans Petter Selasky wrote:
> Fixes compilation under FreeBSD.

This looks good, but there are other places which uses the same types:

https://git.linuxtv.org/v4l-utils.git/tree/utils/keytable/keytable.c#n58

https://git.linuxtv.org/v4l-utils.git/tree/utils/keytable/keytable.c#n85

Do these not affect the build?

> 
> Signed-off-by: Hans Petter Selasky <hps@selasky.org>
> ---
>  utils/common/keymap.h | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/utils/common/keymap.h b/utils/common/keymap.h
> index 99833827..dc198bc1 100644
> --- a/utils/common/keymap.h
> +++ b/utils/common/keymap.h
> @@ -2,6 +2,8 @@
>  #ifndef __KEYMAP_H
>  #define __KEYMAP_H

Your patch got mangled, there two spaces before the # on these two lines.

Thanks

Sean

> 
> +#include <stdint.h>
> +
>  struct keymap {
>  	struct keymap *next;
>  	char *name;
> @@ -20,16 +22,16 @@ struct protocol_param {
> 
>  struct scancode_entry {
>  	struct scancode_entry *next;
> -	u_int64_t scancode;
> +	uint64_t scancode;
>  	char *keycode;
>  };
> 
>  struct raw_entry {
>  	struct raw_entry *next;
> -	u_int64_t scancode;
> -	u_int32_t raw_length;
> +	uint64_t scancode;
> +	uint32_t raw_length;
>  	char *keycode;
> -	u_int32_t raw[1];
> +	uint32_t raw[1];
>  };
> 
>  void free_keymap(struct keymap *map);
> -- 
> 2.27.0