From: Lukas Middendorf <kernel@tuxforce.de>
To: linux-media@vger.kernel.org
Cc: Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Lukas Middendorf <kernel@tuxforce.de>
Subject: [PATCH 2/2] media: si2168: also cache Si2168 B40 fallback firmware
Date: Thu, 13 Aug 2020 23:45:38 +0200 [thread overview]
Message-ID: <20200813214538.8474-2-kernel@tuxforce.de> (raw)
In-Reply-To: <20200813214538.8474-1-kernel@tuxforce.de>
we can not know beforehand whether we have to access that firmware
file during resume. We just request the caching so we don't run
into any problems later
Signed-off-by: Lukas Middendorf <kernel@tuxforce.de>
---
drivers/media/dvb-frontends/si2168.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
index ea4b2d91697e..f2dd1deb75ff 100644
--- a/drivers/media/dvb-frontends/si2168.c
+++ b/drivers/media/dvb-frontends/si2168.c
@@ -768,6 +768,19 @@ static int si2168_probe(struct i2c_client *client,
dev->firmware_name);
}
+ /* also request caching of fw for Si2168 B40 under its old file name.
+ * Since we can't know now whether we might have to access that file,
+ * we just make sure we have that covered
+ */
+ if (dev->chip_id == SI2168_CHIP_ID_B40) {
+ ret = firmware_request_cache(&client->dev, SI2168_B40_FIRMWARE_FALLBACK);
+ if (ret) {
+ dev_err(&client->dev,
+ "firmware caching for '%s' failed\n",
+ SI2168_B40_FIRMWARE_FALLBACK);
+ }
+ }
+
return 0;
err_kfree:
kfree(dev);
--
2.26.2
next prev parent reply other threads:[~2020-08-13 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 21:45 [PATCH 1/2] media: si2168: request caching of firmware to make it available on resume Lukas Middendorf
2020-08-13 21:45 ` Lukas Middendorf [this message]
2020-08-13 21:55 ` [PATCH 2/2] media: si2168: also cache Si2168 B40 fallback firmware Luis Chamberlain
2021-04-01 14:46 ` Lukas Middendorf
2020-08-13 21:54 ` [PATCH 1/2] media: si2168: request caching of firmware to make it available on resume Luis Chamberlain
2021-04-01 14:42 ` Lukas Middendorf
2021-04-02 18:04 ` Luis Chamberlain
2021-04-09 11:29 ` Mauro Carvalho Chehab
2021-04-09 16:58 ` Luis Chamberlain
2021-04-09 22:02 ` Lukas Middendorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813214538.8474-2-kernel@tuxforce.de \
--to=kernel@tuxforce.de \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox