From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Benoit Parrot <bparrot@ti.com>
Subject: Re: [PATCH] media: ti-vpe: cal: Fix compilation on 32-bit ARM
Date: Mon, 24 Aug 2020 13:54:22 +0300 [thread overview]
Message-ID: <20200824105422.GB6002@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20200824092303.GP7145@valkosipuli.retiisi.org.uk>
On Mon, Aug 24, 2020 at 12:23:04PM +0300, Sakari Ailus wrote:
> On Sun, Aug 23, 2020 at 08:02:57AM +0300, Laurent Pinchart wrote:
> > When compiled on 32-bit ARM, the CAL driver fails with the FIELD_PREP()
> > macro complaining that the mask is not constant. While all callers of
> > the inline cal_write_field() function pass a constant mask, the mask
> > parameter itself is a variable, which likely doesn't please the
> > compiler.
> >
> > Fix it by replacing FIELD_PREP() with a manual implementation.
> >
> > Fixes: 50797fb30b95 ("media: ti-vpe: cal: Turn reg_(read|write)_field() into inline functions")
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks!
>
> Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
And I forgot to add
Reported-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Tomi, will you handle this patch ? Could you add the tags ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2020-08-24 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 5:02 [PATCH] media: ti-vpe: cal: Fix compilation on 32-bit ARM Laurent Pinchart
2020-08-24 9:23 ` Sakari Ailus
2020-08-24 10:54 ` Laurent Pinchart [this message]
2020-08-25 12:11 ` Tomi Valkeinen
2020-08-25 12:19 ` Laurent Pinchart
2020-08-25 12:51 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824105422.GB6002@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bparrot@ti.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).