From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: anant.thazhemadam@gmail.com
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] staging: media-atomisp : fix "dubious: !x | !y" sparse warning
Date: Wed, 26 Aug 2020 03:34:26 +0530 [thread overview]
Message-ID: <20200825220437.11214-1-anant.thazhemadam@gmail.com> (raw)
Upon running sparse, "warning: dubious: !x | !y" is brought to notice
for this file. This patch fixes that warning.
If there's a specific reason that this change is considered undesirable,
please do let me know why.
Thanks.
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
---
.../media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
index 358cb7d2cd4c..3b850bb2d39d 100644
--- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
+++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c
@@ -58,7 +58,7 @@ sh_css_vf_downscale_log2(
unsigned int ds_log2 = 0;
unsigned int out_width;
- if ((!out_info) | (!vf_info))
+ if ((!out_info) || (!vf_info))
return -EINVAL;
out_width = out_info->res.width;
--
2.25.1
next reply other threads:[~2020-08-25 22:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 22:04 Anant Thazhemadam [this message]
2020-08-26 9:50 ` [PATCH] staging: media-atomisp : fix "dubious: !x | !y" sparse warning Dan Carpenter
2020-08-26 11:09 ` [PATCH v2] staging: media/atomisp " Anant Thazhemadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825220437.11214-1-anant.thazhemadam@gmail.com \
--to=anant.thazhemadam@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox