Re: [PATCH v2 3/4] media: sunxi: sun6i-csi: Add support of MIPI CSI-2 for A83T

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4136 bytes --]

Hi "Kévin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on sunxi/sunxi/for-next pza/reset/next v5.9-rc2 next-20200828]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/K-vin-L-h-pital/Support-of-MIPI-CSI-2-for-A83T/20200828-212110
base:   git://linuxtv.org/media_tree.git master
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/platform/sunxi/sun6i-csi/sun8i_a83t_mipi_csi2.c:101:6: warning: no previous prototype for 'sun6i_mipi_csi_init' [-Wmissing-prototypes]
     101 | void sun6i_mipi_csi_init(struct sun6i_csi_dev *sdev)
         |      ^~~~~~~~~~~~~~~~~~~

# https://github.com/0day-ci/linux/commit/7e8c8e3031ceba91b0a690fe805069b7069540a3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review K-vin-L-h-pital/Support-of-MIPI-CSI-2-for-A83T/20200828-212110
git checkout 7e8c8e3031ceba91b0a690fe805069b7069540a3
vim +/sun6i_mipi_csi_init +101 drivers/media/platform/sunxi/sun6i-csi/sun8i_a83t_mipi_csi2.c

   100	
 > 101	void sun6i_mipi_csi_init(struct sun6i_csi_dev *sdev)
   102	{
   103		regmap_update_bits(sdev->regmap, MIPI_CSI2_CTRL_REG,
   104				   MIPI_CSI2_CTRL_REG_RSTN, MIPI_CSI2_CTRL_REG_RSTN);
   105		regmap_write(sdev->regmap, MIPI_CSI2_RX_PKT_NUM_REG, 0xb8d257f8);
   106		sun6i_dphy_first_init(sdev);
   107		regmap_write(sdev->regmap, MIPI_CSI2_RSVD1_REG,
   108			     HW_LOCK_REGISTER_VALUE_1);
   109		regmap_write(sdev->regmap, MIPI_CSI2_RSVD2_REG,
   110			     HW_LOCK_REGISTER_VALUE_2);
   111		regmap_write(sdev->regmap, MIPI_CSI2_RX_PKT_NUM_REG, 0);
   112		regmap_write(sdev->regmap, MIPI_CSI2_VCDT0_REG, 0);
   113		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   114				   MIPI_CSI2_CFG_REG_SYNC_DLY_CYCLE_MASK,
   115				   MIPI_CSI2_CFG_REG_SYNC_DLY_CYCLE(0x11));
   116		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   117				   MIPI_CSI2_CFG_REG_N_BYTE, 0);
   118		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   119				   MIPI_CSI2_CFG_REG_YC_SWAB, 0);
   120		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   121				   MIPI_CSI2_CFG_REG_NONE_UNPKT_RX_MODE,
   122				   MIPI_CSI2_CFG_REG_NONE_UNPKT_RX_MODE);
   123		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   124				   MIPI_CSI2_CFG_REG_UNPKT_EN,
   125				   MIPI_CSI2_CFG_REG_UNPKT_EN);
   126		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   127				   MIPI_CSI2_CFG_REG_BYPASS_ECC_EN,
   128				   MIPI_CSI2_CFG_REG_BYPASS_ECC_EN);
   129		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   130				   MIPI_CSI2_CFG_REG_SYNC_EN,
   131				   MIPI_CSI2_CFG_REG_SYNC_EN);
   132		sun6i_dphy_second_init(sdev);
   133		regmap_update_bits(sdev->regmap, MIPI_CSI2_CTRL_REG,
   134				   MIPI_CSI2_CTRL_REG_RSTN, MIPI_CSI2_CTRL_REG_RSTN);
   135		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   136				   MIPI_CSI2_CFG_REG_SYNC_DLY_CYCLE_MASK,
   137				   MIPI_CSI2_CFG_REG_SYNC_DLY_CYCLE(0x08));
   138		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   139				   MIPI_CSI2_CFG_REG_NONE_UNPKT_RX_MODE, 0);
   140		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   141				   MIPI_CSI2_CFG_REG_BYPASS_ECC_EN, 0);
   142		regmap_update_bits(sdev->regmap, MIPI_CSI2_CFG_REG,
   143				   MIPI_CSI2_CFG_REG_SYNC_EN, 0);
   144	}
   145	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63225 bytes --]