From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2562FC4346E for ; Sun, 27 Sep 2020 11:05:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD3DF22207 for ; Sun, 27 Sep 2020 11:05:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601204736; bh=csgnXel9n0hDsR7RqcpD0iELpaB86a7qOohf3UehOUI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=v6eDZxXwdZPMEqxHNzfwSSxde9JL7mZVxIa4QzZy2DlF5DBDNcDxK6Ca8a7pCngPY s16FQvlspnyqpv8j7MlD76gOj28GBXa1UcwrytovnpY8GYVXgyh4e+w4aSb+3iE/tQ 7lXyf9mb4FH24QNPgB1QobUXoEIncl8Hu7yqCrm4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726239AbgI0LFg (ORCPT ); Sun, 27 Sep 2020 07:05:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:37222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbgI0LFg (ORCPT ); Sun, 27 Sep 2020 07:05:36 -0400 Received: from coco.lan (ip5f5ad5c3.dynamic.kabel-deutschland.de [95.90.213.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08633221EC; Sun, 27 Sep 2020 11:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601204735; bh=csgnXel9n0hDsR7RqcpD0iELpaB86a7qOohf3UehOUI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Io696w7HC9Kx3d/XolIEVtO3GHO8YzpXQfnE5zJbF3J4vO81nK0883PRjGast9quI nWqx3r4Ara+PfVbiJ5SA8GzHGwxAmdKh68O1MBon40FJcMRHjxN1rmC2xUTDLEci+J qFcyI7u+LkerdL93pyCT4rZ1O/l7q2ZZK3l69Gzw= Date: Sun, 27 Sep 2020 13:05:28 +0200 From: Mauro Carvalho Chehab To: Dafna Hirschfeld Cc: helen.koike@collabora.com, hverkuil@xs4all.nl, linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, ezequiel@collabora.com, kernel@collabora.com, dafna3@gmail.com, sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org, tfiga@chromium.org Subject: Re: [PATCH v3 12/12] media: staging: rkisp1: cap: protect access to buf with the spin lock Message-ID: <20200927130528.374342ef@coco.lan> In-Reply-To: <672c5ca3-a5d1-a1dc-5cc8-3a802208310e@collabora.com> References: <20200922113402.12442-1-dafna.hirschfeld@collabora.com> <20200922113402.12442-13-dafna.hirschfeld@collabora.com> <20200927114326.7446d970@coco.lan> <672c5ca3-a5d1-a1dc-5cc8-3a802208310e@collabora.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Em Sun, 27 Sep 2020 11:54:10 +0200 Dafna Hirschfeld escreveu: > Am 27.09.20 um 11:43 schrieb Mauro Carvalho Chehab: > > Em Tue, 22 Sep 2020 13:34:02 +0200 > > Dafna Hirschfeld escreveu: > > > >> The function 'rkisp1_stream_start' calls 'rkisp1_set_next_buf' > >> which access the buffers, so the call should be protected by > >> taking the cap->buf.lock. > >> After this patch, all locks are reviewed and commented so remove > >> the TODO item "review and comment every lock" > >> > >> Signed-off-by: Dafna Hirschfeld > >> --- > >> drivers/staging/media/rkisp1/TODO | 1 - > >> drivers/staging/media/rkisp1/rkisp1-capture.c | 2 ++ > >> 2 files changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/staging/media/rkisp1/TODO b/drivers/staging/media/rkisp1/TODO > >> index f0c90d1c86a8..9662e9b51c7f 100644 > >> --- a/drivers/staging/media/rkisp1/TODO > >> +++ b/drivers/staging/media/rkisp1/TODO > >> @@ -1,6 +1,5 @@ > >> * Fix pad format size for statistics and parameters entities. > >> * Fix checkpatch errors. > >> -* Review and comment every lock > >> * Handle quantization > >> * streaming paths (mainpath and selfpath) check if the other path is streaming > >> in several places of the code, review this, specially that it doesn't seem it > > > > > > FYI, > > > > There was a trivial context conflict here. Basically, the upstream > > version has this: > > > > > > * Add uapi docs. Remember to add documentation of how quantization is handled. > > > > I solved the conflict, but as some patches for rkisp1 got merged > > on a different pull request, and there were some uapi docs at the > > other PR, maybe this would need to be revisited. > > I added the "Configuring Quantization" documentation in Documentation/admin-guide/media/rkisp1.rst > so the TODO item > "* Add uapi docs. Remember to add documentation of how quantization is handled." > can be removed. Ok. Please send a followup patch with a "fixes: " tag mentioned the commit that added it. Thanks, Mauro