From: LABBE Corentin <clabbe@baylibre.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] zoran: fix sparse warnings
Date: Fri, 2 Oct 2020 09:29:09 +0200 [thread overview]
Message-ID: <20201002072909.GD15586@Red> (raw)
In-Reply-To: <20200928132831.1587872-3-hverkuil-cisco@xs4all.nl>
On Mon, Sep 28, 2020 at 03:28:31PM +0200, Hans Verkuil wrote:
> The output is not fully supported yet, so some ops are
> commented out. Also comment out the corresponding callbacks to prevent
> these sparse warnings:
>
> drivers/staging/media/zoran/zoran_driver.c:656:12: warning: 'zoran_s_output' defined but not used [-Wunused-function]
> 656 | static int zoran_s_output(struct file *file, void *__fh, unsigned int output)
> | ^~~~~~~~~~~~~~
> drivers/staging/media/zoran/zoran_driver.c:649:12: warning: 'zoran_g_output' defined but not used [-Wunused-function]
> 649 | static int zoran_g_output(struct file *file, void *__fh, unsigned int *output)
> | ^~~~~~~~~~~~~~
> drivers/staging/media/zoran/zoran_driver.c:635:12: warning: 'zoran_enum_output' defined but not used [-Wunused-function]
> 635 | static int zoran_enum_output(struct file *file, void *__fh,
> | ^~~~~~~~~~~~~~~~~
> drivers/staging/media/zoran/zoran_driver.c:302:12: warning: 'zoran_enum_fmt_vid_overlay' defined but not used [-Wunused-function]
> 302 | static int zoran_enum_fmt_vid_overlay(struct file *file, void *__fh,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/staging/media/zoran/zoran_driver.c:294:12: warning: 'zoran_enum_fmt_vid_out' defined but not used [-Wunused-function]
> 294 | static int zoran_enum_fmt_vid_out(struct file *file, void *__fh,
> | ^~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
Hello
What about using "ifdef CONFIG_ZORAN_OUTPUT" instead of "ifdef 0"
Otherwise:
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Regards
next prev parent reply other threads:[~2020-10-02 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 13:28 [PATCH 0/2] zoran: sparse/smatch fixes Hans Verkuil
2020-09-28 13:28 ` [PATCH 1/2] zoran: fix smatch warning Hans Verkuil
2020-10-02 7:29 ` LABBE Corentin
2020-09-28 13:28 ` [PATCH 2/2] zoran: fix sparse warnings Hans Verkuil
2020-10-02 7:29 ` LABBE Corentin [this message]
2020-10-02 9:05 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002072909.GD15586@Red \
--to=clabbe@baylibre.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).