linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: LABBE Corentin <clabbe@baylibre.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] zoran: fix smatch warning
Date: Fri, 2 Oct 2020 09:29:36 +0200	[thread overview]
Message-ID: <20201002072936.GE15586@Red> (raw)
In-Reply-To: <20200928132831.1587872-2-hverkuil-cisco@xs4all.nl>

On Mon, Sep 28, 2020 at 03:28:30PM +0200, Hans Verkuil wrote:
> drivers/staging/media/zoran/zoran_device.c:941 zoran_irq() warn: inconsistent indenting
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
>  drivers/staging/media/zoran/zoran_device.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
> index 1fe91e16658b..ecd6c5293a87 100644
> --- a/drivers/staging/media/zoran/zoran_device.c
> +++ b/drivers/staging/media/zoran/zoran_device.c
> @@ -938,10 +938,10 @@ irqreturn_t zoran_irq(int irq, void *dev_id)
>  				pci_err(zr->pci_dev, "JPG IRQ when not in good mode\n");
>  				return IRQ_HANDLED;
>  			}
> -		zr->frame_num++;
> -		zoran_reap_stat_com(zr);
> -		zoran_feed_stat_com(zr);
> -		return IRQ_HANDLED;
> +			zr->frame_num++;
> +			zoran_reap_stat_com(zr);
> +			zoran_feed_stat_com(zr);
> +			return IRQ_HANDLED;
>  		}
>  		/* unused interrupts */
>  	}
> -- 
> 2.28.0
> 

Hello

Acked-by: Corentin Labbe <clabbe@baylibre.com>

Thanks

  reply	other threads:[~2020-10-02  7:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 13:28 [PATCH 0/2] zoran: sparse/smatch fixes Hans Verkuil
2020-09-28 13:28 ` [PATCH 1/2] zoran: fix smatch warning Hans Verkuil
2020-10-02  7:29   ` LABBE Corentin [this message]
2020-09-28 13:28 ` [PATCH 2/2] zoran: fix sparse warnings Hans Verkuil
2020-10-02  7:29   ` LABBE Corentin
2020-10-02  9:05     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201002072936.GE15586@Red \
    --to=clabbe@baylibre.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).