Re: [PATCH v2 00/19] media: Add new pixel formats for Xilinx v-frmbuf

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

On Tue, Nov 03, 2020 at 10:57:52AM +0200, Sakari Ailus wrote:
> On Tue, Nov 03, 2020 at 12:40:43AM +0200, Laurent Pinchart wrote:
> > Hello,
> > 
> > This patch series adds a set of new pixel formats needed for the Xilinx
> > Video Frame Buffer Read/Write IP cores (see [1]).
> > 
> > Compared to v1, the series has been extended to include semi-planar YUV
> > formats. The code is now based on v5.10-rc2, which uses SPDX license
> > headers for the media documentation, so new files have been switched to
> > do so as well. Review comments have also been incorported, thank you
> > Hans and Nicolas for providing feedback on v1.
> > 
> > Documentation of the pixel formats has grown organically in V4L2, and
> > while it is fairly complete and detailed, it also duplicates lots of
> > information. I've thus decided to bite the bullet, and try to
> > consolidate the documentation first before adding new formats.
> > 
> > The first three patches address minor issues in videodev2.h, removing a
> > comment that belongs to a commit message instead (01/19) and moving two
> > misplaced formats to where they belong (02/19 and 03/19).
> > 
> > The next three patches refactor documentation for the RGB formats. Patch
> > 04/19 removes a confusing table (that likely made sense when it was
> > added, but not anymore), 05/19 adds a section title for the deprecated
> > RGB formats to increase clarity, and patch 06/19 documents the naming
> > scheme followed by our RGB formats. There are two separate naming
> > schemes, used by 8- and 16-bit formats on one side, and 24- and 32-bit
> > formats on the other side. The former matches the naming conventions of
> > DRM, while the latter doesn't, which has often led to confusion and
> > errors. This can't be changed, but it's now clearly documented.
> 
> The patches look nice but it'd be useful to see the resulting
> documentation. Would you be able to upload that somewhere for reviewers to
> access?

Sure. Here you are: https://www.ideasonboard.org/media/uapi/v4l/pixfmt.html

-- 
Regards,

Laurent Pinchart