Re: [PATCH RESEND v2 0/2] media: rc: gpio-ir-recv: add timeout property

[Sean Young <sean@mess.org>]

On Mon, Nov 09, 2020 at 04:23:09PM +0100, Michael Klein wrote:
> The default recorder timeout of 125ms is too high for some BPF protocol 
> decoders when a remote sends repeat codes at high rates. This makes the 
> timeout configurable via the devicetree.

To be honest, 125ms is too much by any measurement. The longest space
in any protocol I'm aware of is 40ms in the sharp ir protocol. I think
changing IR_DEFAUL_TIMEOUT to something like 50ms would make sense.

Also, when an BPF protocol is loaded, user-space can set the timeout
with the LIRC_SET_REC_TIMEOUT ioctl which can depend on the protocol
(set to longest space + 10ms error margin). This would mean that the
bare minimum timeout can be set, which means decoding is as responsive
as can be.

I'm not sure that device tree is really the place for this.

Thanks,

Sean


> 
> Changes in v2:
>   fix checkpatch.pl warnings
> 
> Michael Klein (2):
>   media: rc: gpio-ir-recv: add recorder timeout property
>   media: bindings: media: gpio-ir-receiver: add linux,timeout-us
>     property
> 
>  .../devicetree/bindings/media/gpio-ir-receiver.txt          | 3 +++
>  Documentation/devicetree/bindings/media/rc.yaml             | 6 ++++++
>  drivers/media/rc/gpio-ir-recv.c                             | 3 ++-
>  3 files changed, 11 insertions(+), 1 deletion(-)
> 
> -- 
> 2.28.0