From: Michael Klein <michael@fossekall.de>
To: Sean Young <sean@mess.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH RESEND v2 0/2] media: rc: gpio-ir-recv: add timeout property
Date: Tue, 10 Nov 2020 21:34:32 +0100 [thread overview]
Message-ID: <20201110203432.GA3173985@a98shuttle.de> (raw)
In-Reply-To: <20201110131918.GA29219@gofer.mess.org>
On Tue, Nov 10, 2020 at 01:19:18PM +0000, Sean Young wrote:
>On Tue, Nov 10, 2020 at 01:48:05PM +0100, Michael Klein wrote:
>> On Tue, Nov 10, 2020 at 10:17:27AM +0000, Sean Young wrote:
>> > On Mon, Nov 09, 2020 at 04:23:09PM +0100, Michael Klein wrote:
>> > > The default recorder timeout of 125ms is too high for some BPF protocol
>> > > decoders when a remote sends repeat codes at high rates. This makes the
>> > > timeout configurable via the devicetree.
>> >
>> > To be honest, 125ms is too much by any measurement. The longest space
>> > in any protocol I'm aware of is 40ms in the sharp ir protocol. I think
>> > changing IR_DEFAUL_TIMEOUT to something like 50ms would make sense.
>>
>> Seconded. I'm happy to prepare a patch if changing the default value is
>> acceptable.
>
>Actually I don't understand why the high timeout is an issue. It means that
>between ir messages you don't get a LIRC_TIMEOUT, just a LIRC_SPACE. Why is
>this a problem?
Never mind; this turned out do be a problem of the BPF protocol decoder,
which relied on LIRC_TIMEOUT to terminate each IR message. After
overhaul it is quite a bit simpler now and works fine with the long
timeout.
Thank you for your insights.
Michael
prev parent reply other threads:[~2020-11-10 20:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 15:35 [PATCH v2 0/2] media: rc: gpio-ir-recv: add timeout property Michael Klein
2020-11-05 15:35 ` [PATCH v2 1/2] media: rc: gpio-ir-recv: add recorder " Michael Klein
2020-11-09 15:23 ` [PATCH RESEND " Michael Klein
2020-11-05 15:35 ` [PATCH v2 2/2] media: bindings: media: gpio-ir-receiver: add linux,timeout-us property Michael Klein
2020-11-09 15:23 ` [PATCH RESEND " Michael Klein
2020-11-09 15:23 ` [PATCH RESEND v2 0/2] media: rc: gpio-ir-recv: add timeout property Michael Klein
2020-11-10 10:17 ` Sean Young
2020-11-10 12:48 ` Michael Klein
2020-11-10 13:19 ` Sean Young
2020-11-10 20:34 ` Michael Klein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110203432.GA3173985@a98shuttle.de \
--to=michael@fossekall.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).