From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4280C4742C for ; Wed, 11 Nov 2020 18:29:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BE7620797 for ; Wed, 11 Nov 2020 18:29:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbgKKS3B (ORCPT ); Wed, 11 Nov 2020 13:29:01 -0500 Received: from iodev.co.uk ([46.30.189.100]:50300 "EHLO iodev.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbgKKS3B (ORCPT ); Wed, 11 Nov 2020 13:29:01 -0500 X-Greylist: delayed 588 seconds by postgrey-1.27 at vger.kernel.org; Wed, 11 Nov 2020 13:29:00 EST Received: from abuya (118.130.77.188.dynamic.jazztel.es [188.77.130.118]) by iodev.co.uk (Postfix) with ESMTPSA id 4DBD013403; Wed, 11 Nov 2020 19:19:09 +0100 (CET) Date: Wed, 11 Nov 2020 19:21:26 +0100 From: Ismael Luceno To: Qinglang Miao Cc: Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: solo6x10: fix missing snd_card_free in error handling case Message-ID: <20201111182126.GE22827@abuya> References: <20201111032201.17879-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111032201.17879-1-miaoqinglang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 11/Nov/2020 11:22, Qinglang Miao wrote: > Fix to goto snd_error in error handling case when fails > to do snd_ctl_add, as done elsewhere in this function. > > Fixes: 28cae868cd24 ("[media] solo6x10: move out of staging into drivers/media/pci.") > Reported-by: Hulk Robot > Signed-off-by: Qinglang Miao > --- > drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c > index 906ce86437ae..d137b94869d8 100644 > --- a/drivers/media/pci/solo6x10/solo6x10-g723.c > +++ b/drivers/media/pci/solo6x10/solo6x10-g723.c > @@ -385,7 +385,7 @@ int solo_g723_init(struct solo_dev *solo_dev) > > ret = snd_ctl_add(card, snd_ctl_new1(&kctl, solo_dev)); > if (ret < 0) > - return ret; > + goto snd_error; > > ret = solo_snd_pcm_init(solo_dev); > if (ret < 0) > -- > 2.23.0 > Signed-off-by: Ismael Luceno