From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E190C56202 for ; Wed, 18 Nov 2020 07:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A91322228 for ; Wed, 18 Nov 2020 07:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726519AbgKRHsR (ORCPT ); Wed, 18 Nov 2020 02:48:17 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:36417 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725772AbgKRHsQ (ORCPT ); Wed, 18 Nov 2020 02:48:16 -0500 Received: by mail-ed1-f65.google.com with SMTP id m16so957325edr.3; Tue, 17 Nov 2020 23:48:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/VBymVKVFuIaMs6diTaKJdglBbHoKWE5HN40ZxS82fM=; b=ZoQXuxH+O+bMZf6e01a5OMk9ERHYOga+zduslROkrb0PoC1qdpsAMBS9m/r9xs3xdH pOAsqdM5IZIe1OxHvwq5MbntFv8ZylO2ufc66o6O9BzN42J4XzXkM2kzOe2zcX4X50+J 8vfTwwj0xleWzXBBKaa0wNRfEjexpfgMkMVPS1jJbBsPNbakT5sK3J1r9WOZVI0DPg0U EXSKz+EUgP3H4o8h8t7eu3FY72qnHRXJxGr/fs2Tw1qYAcbj0upMEdRAJfaphMMg7JEw fBJzInSNZAL0tFu0X5HbAoaCGTIyHBJgjL+ojNgF51Ueb+99jWoTXX+Hc72pAr+Hxp+D rlXQ== X-Gm-Message-State: AOAM532hxQ6o2qZiFQE4V99fQQOBcX0g+PRAVF52+kEU5JTFEIah4p27 ZhqHJry+Vx9AKUUNfEMFZpQ= X-Google-Smtp-Source: ABdhPJx+aZjGIA58JBNNsU2EYJuORCMi9eVDKQ3IfVQdHZjH8ummbU4/k0jvYclGpHK/bGP8ytcepg== X-Received: by 2002:aa7:c2c3:: with SMTP id m3mr24597168edp.361.1605685694599; Tue, 17 Nov 2020 23:48:14 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id g7sm13224731edl.5.2020.11.17.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 23:48:13 -0800 (PST) Date: Wed, 18 Nov 2020 08:48:12 +0100 From: Krzysztof Kozlowski To: Stephen Boyd Cc: Chen-Yu Tsai , Greg Kroah-Hartman , Jaroslav Kysela , Jernej Skrabec , Liam Girdwood , Mark Brown , Mauro Carvalho Chehab , Maxime Ripard , Michael Turquette , Sakari Ailus , Takashi Iwai , alsa-devel@alsa-project.org, devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 1/3] clk: fix redefinition of clk_prepare on MIPS with HAVE_LEGACY_CLK Message-ID: <20201118074812.GA5803@kozik-lap> References: <20201115170950.304460-1-krzk@kernel.org> <20201115170950.304460-2-krzk@kernel.org> <160568531746.60232.15496517544781609246@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <160568531746.60232.15496517544781609246@swboyd.mtv.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Nov 17, 2020 at 11:41:57PM -0800, Stephen Boyd wrote: > Quoting Krzysztof Kozlowski (2020-11-15 09:09:48) > > COMMON_CLK even though is a user-selectable symbol, is still selected by > > multiple other config options. COMMON_CLK should not be used when > > legacy clocks are provided by architecture, so it correctly depends on > > !HAVE_LEGACY_CLK. > > > > However it is possible to create a config which selects both COMMON_CLK > > (by SND_SUN8I_CODEC) and HAVE_LEGACY_CLK (by SOC_RT305X) which leads to > > Why is SND_SUN8I_CODEC selecting COMMON_CLK? Or really, why is > SOC_RT305X selecting HAVE_LEGACY_CLK? The SND_SUN8I_CODEC I fixed in following patch (I sent separately v2 of it). The SOC_RT305X select HAVE_LEGACY_CLK? because it is an old, Ralink platform, not converted to Common clock frm. Few clock operations are defined in: arch/mips/ralink/clk.c Best regards, Krzysztof