Linux Media Controller development
 help / color / mirror / Atom feed
From: "Enrico Weigelt, metux IT consult" <info@metux.net>
To: linux-kernel@vger.kernel.org
Cc: rspringer@google.com, toddpoynor@google.com,
	benchan@chromium.org, rcy@google.com,
	laurent.pinchart@ideasonboard.com, mchehab@kernel.org,
	f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com, nsaenzjulienne@suse.de,
	speakup@linux-speakup.org, devel@driverdev.osuosl.org,
	linux-media@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 05/11] drivers: staging: media: remove unneeded MODULE_VERSION() call
Date: Thu,  3 Dec 2020 13:47:57 +0100	[thread overview]
Message-ID: <20201203124803.23390-5-info@metux.net> (raw)
In-Reply-To: <20201203124803.23390-1-info@metux.net>

Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-tree drivers, the kernel version matters. The code received lots of
changes, but module version remained constant, since the driver landed in
mainline. So, this version doesn't seem have any practical meaning anymore.

Signed-off-by: Enrico Weigelt <info@metux.net>
---
 drivers/staging/media/omap4iss/iss.c       | 1 -
 drivers/staging/media/omap4iss/iss_video.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index e06ea7ea1e50..dae9073e7d3c 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -1349,4 +1349,3 @@ module_platform_driver(iss_driver);
 MODULE_DESCRIPTION("TI OMAP4 ISS driver");
 MODULE_AUTHOR("Sergio Aguirre <sergio.a.aguirre@gmail.com>");
 MODULE_LICENSE("GPL");
-MODULE_VERSION(ISS_VIDEO_DRIVER_VERSION);
diff --git a/drivers/staging/media/omap4iss/iss_video.h b/drivers/staging/media/omap4iss/iss_video.h
index 8b3dd92021e1..526281bf0051 100644
--- a/drivers/staging/media/omap4iss/iss_video.h
+++ b/drivers/staging/media/omap4iss/iss_video.h
@@ -18,7 +18,6 @@
 #include <media/videobuf2-dma-contig.h>
 
 #define ISS_VIDEO_DRIVER_NAME		"issvideo"
-#define ISS_VIDEO_DRIVER_VERSION	"0.0.2"
 
 struct iss_device;
 struct iss_video;
-- 
2.11.0


  parent reply	other threads:[~2020-12-03 12:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 12:47 [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 02/11] drivers: staging: gasket: " Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 03/11] drivers: staging: gdm724x: " Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 04/11] drivers: staging: goldfish: " Enrico Weigelt, metux IT consult
2020-12-04 15:47   ` Greg KH
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult [this message]
2020-12-03 12:47 ` [PATCH 06/11] drivers: staging: qlge: " Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 07/11] drivers: staging: vc04_services: " Enrico Weigelt, metux IT consult
2020-12-03 12:48 ` [PATCH 08/11] drivers: staging: rtl8188eu: " Enrico Weigelt, metux IT consult
2020-12-03 12:48 ` [PATCH 09/11] drivers: staging: rtl8192e: " Enrico Weigelt, metux IT consult
2020-12-03 12:48 ` [PATCH 10/11] drivers: staging: rtl8723bs: " Enrico Weigelt, metux IT consult
2020-12-03 12:48 ` [PATCH 11/11] " Enrico Weigelt, metux IT consult
2020-12-03 13:25 ` [PATCH 01/11] drivers: staging: speakup: " Greg KH
2020-12-03 13:56   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201203124803.23390-5-info@metux.net \
    --to=info@metux.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=benchan@chromium.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=f.fainelli@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=rcy@google.com \
    --cc=rjui@broadcom.com \
    --cc=rspringer@google.com \
    --cc=sbranden@broadcom.com \
    --cc=speakup@linux-speakup.org \
    --cc=toddpoynor@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox