From: Dan Carpenter <dan.carpenter@oracle.com>
To: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org,
ij72uhux@stud.informatik.uni-erlangen.de,
sakari.ailus@linux.intel.com, mchehab@kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 01/12] media: atomsip: Convert comments to C99 initializers
Date: Tue, 8 Dec 2020 13:21:44 +0300 [thread overview]
Message-ID: <20201208102144.GA2767@kadam> (raw)
In-Reply-To: <20201207192638.15219-2-Philipp.Gerlesberger@fau.de>
On Mon, Dec 07, 2020 at 08:26:27PM +0100, Philipp Gerlesberger wrote:
> The struct initalizers have been changed as recommended on
> https://kernelnewbies.org/KernelJanitors/Todo
>
> Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
> Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
> ---
> .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 30 +++++++++----------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> index b4f53be18e7f..af61d05e88d3 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> @@ -31,33 +31,33 @@ static struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES];
> * @brief VBUF resource pool - refpool
> */
> static struct ia_css_rmgr_vbuf_pool refpool = {
> - false, /* copy_on_write */
> - false, /* recycle */
> - 0, /* size */
> - 0, /* index */
> - NULL, /* handles */
> + .copy_on_write = false,
> + .recycle = false,
> + .size = 0,
> + .index = 0,
> + .handles = NULL,
If you're using C99 initializers then you can remove all the false, 0
and NULL members.
regards,
dan carpenter
next prev parent reply other threads:[~2020-12-08 10:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 19:26 [PATCH 00/12] media: atomisp: Codingstyle Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 01/12] media: atomsip: Convert comments to C99 initializers Philipp Gerlesberger
2020-12-08 10:21 ` Dan Carpenter [this message]
2020-12-07 19:26 ` [PATCH 02/12] media: atomisp: Fix Block Comments Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 04/12] media: atomisp: Fix OPEN_ENDED_LINE Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 05/12] media: atomisp: Fix overlong line Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 06/12] media: atomisp: Add parentheses Philipp Gerlesberger
2020-12-08 11:30 ` Dan Carpenter
2020-12-07 19:26 ` [PATCH 07/12] media: atomisp: Fix funciton decleration Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 08/12] media: atomisp: Delete braces Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 11/12] media: atomisp: Write function decleration in one line Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208102144.GA2767@kadam \
--to=dan.carpenter@oracle.com \
--cc=Philipp.Gerlesberger@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ij72uhux@stud.informatik.uni-erlangen.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).