From: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
To: linux-kernel@vger.kernel.org
Cc: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>,
ij72uhux@stud.informatik.uni-erlangen.de,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org,
sakari.ailus@linux.intel.com, mchehab@kernel.org
Subject: [PATCH v2 06/12] media: atomisp: Remove defines
Date: Mon, 14 Dec 2020 12:01:50 +0100 [thread overview]
Message-ID: <20201214110156.6152-7-Philipp.Gerlesberger@fau.de> (raw)
In-Reply-To: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de>
Remov defines, they don't make sense.
The programmer should know what things need to be static and what not.
Also leave "inline" out and let the compiler decide
Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
---
.../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
index 9cd3d92b34c9..45b72e98bc9f 100644
--- a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
+++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
@@ -21,10 +21,7 @@
#ifndef __INLINE_RMGR__
#define STORAGE_CLASS_RMGR_H extern
#define STORAGE_CLASS_RMGR_C
-#else /* __INLINE_RMGR__ */
-#define STORAGE_CLASS_RMGR_H static inline
-#define STORAGE_CLASS_RMGR_C static inline
-#endif /* __INLINE_RMGR__ */
+#endif
/**
* @brief Initialize resource manager (host/common)
--
2.20.1
next prev parent reply other threads:[~2020-12-14 11:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 11:01 [PATCH v2 00/12] media: atomisp: Codingstyle Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 01/12] media: atomisp: Convert comments to C99 initializers Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 02/12] media: atomisp: Fix Block Comments Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 04/12] media: atomisp: Fix OPEN_ENDED_LINE Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 05/12] media: atomisp: Fix overlong line Philipp Gerlesberger
2020-12-14 11:01 ` Philipp Gerlesberger [this message]
2021-03-23 13:12 ` [PATCH v2 06/12] media: atomisp: Remove defines Mauro Carvalho Chehab
2020-12-14 11:01 ` [PATCH v2 07/12] media: atomisp: Fix funciton decleration Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 08/12] media: atomisp: Delete braces Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 11/12] media: atomisp: Write function decleration in one line Philipp Gerlesberger
2020-12-14 11:01 ` [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger
2020-12-14 11:53 ` David Laight
2020-12-14 14:16 ` Dan Carpenter
2021-03-23 13:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214110156.6152-7-Philipp.Gerlesberger@fau.de \
--to=philipp.gerlesberger@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ij72uhux@stud.informatik.uni-erlangen.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox