* [PATCH v1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of
@ 2020-12-30 20:44 Andy Shevchenko
2021-01-03 0:11 ` Daniel Scally
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-12-30 20:44 UTC (permalink / raw)
To: yong.zhi, sakari.ailus, bingbu.cao, tian.shu.qiu, mchehab,
linux-media
Cc: Andy Shevchenko, Laurent Pinchart
Add headers that ipu3-cio2.h is direct user of.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
Dan, feel free to incorporate this into your series.
drivers/media/pci/intel/ipu3/ipu3-cio2.h | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
index ccf0b85ae36f..62187ab5ae43 100644
--- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
+++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
@@ -4,8 +4,26 @@
#ifndef __IPU3_CIO2_H
#define __IPU3_CIO2_H
+#include <linux/bits.h>
+#include <linux/dma-mapping.h>
+#include <linux/kernel.h>
+#include <linux/mutex.h>
#include <linux/types.h>
+#include <asm/page.h>
+
+#include <media/media-device.h>
+#include <media/media-entity.h>
+#include <media/v4l2-async.h>
+#include <media/v4l2-dev.h>
+#include <media/v4l2-device.h>
+#include <media/v4l2-subdev.h>
+#include <media/videobuf2-core.h>
+#include <media/videobuf2-v4l2.h>
+
+struct cio2_fbpt_entry; /* defined here, after the first usage */
+struct pci_dev;
+
#define CIO2_NAME "ipu3-cio2"
#define CIO2_DEVICE_NAME "Intel IPU3 CIO2"
#define CIO2_ENTITY_NAME "ipu3-csi2"
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of
2020-12-30 20:44 [PATCH v1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of Andy Shevchenko
@ 2021-01-03 0:11 ` Daniel Scally
2021-01-03 14:45 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Scally @ 2021-01-03 0:11 UTC (permalink / raw)
To: Andy Shevchenko, yong.zhi, sakari.ailus, bingbu.cao, tian.shu.qiu,
mchehab, linux-media
Cc: Laurent Pinchart
Hi Andy
On 30/12/2020 20:44, Andy Shevchenko wrote:
> Add headers that ipu3-cio2.h is direct user of.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
For what it's worth:
Reviewed-by: Daniel Scally <djrscally@gmail.com>
Tested-by: Daniel Scally <djrscally@gmail.com>
> ---
>
> Dan, feel free to incorporate this into your series.
Thanks! I'll add it at the beginning so I can include this header in
cio2-bridge.h, with my tags added too I guess
>
> drivers/media/pci/intel/ipu3/ipu3-cio2.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.h b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> index ccf0b85ae36f..62187ab5ae43 100644
> --- a/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> +++ b/drivers/media/pci/intel/ipu3/ipu3-cio2.h
> @@ -4,8 +4,26 @@
> #ifndef __IPU3_CIO2_H
> #define __IPU3_CIO2_H
>
> +#include <linux/bits.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/kernel.h>
> +#include <linux/mutex.h>
> #include <linux/types.h>
>
> +#include <asm/page.h>
> +
> +#include <media/media-device.h>
> +#include <media/media-entity.h>
> +#include <media/v4l2-async.h>
> +#include <media/v4l2-dev.h>
> +#include <media/v4l2-device.h>
> +#include <media/v4l2-subdev.h>
> +#include <media/videobuf2-core.h>
> +#include <media/videobuf2-v4l2.h>
> +
> +struct cio2_fbpt_entry; /* defined here, after the first usage */
> +struct pci_dev;
> +
> #define CIO2_NAME "ipu3-cio2"
> #define CIO2_DEVICE_NAME "Intel IPU3 CIO2"
> #define CIO2_ENTITY_NAME "ipu3-csi2"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of
2021-01-03 0:11 ` Daniel Scally
@ 2021-01-03 14:45 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2021-01-03 14:45 UTC (permalink / raw)
To: Daniel Scally
Cc: Andy Shevchenko, Yong Zhi, Sakari Ailus, Bingbu Cao, Tian Shu Qiu,
Mauro Carvalho Chehab, Linux Media Mailing List, Laurent Pinchart
On Sun, Jan 3, 2021 at 2:19 AM Daniel Scally <djrscally@gmail.com> wrote:
> On 30/12/2020 20:44, Andy Shevchenko wrote:
> > Add headers that ipu3-cio2.h is direct user of.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> For what it's worth:
>
>
> Reviewed-by: Daniel Scally <djrscally@gmail.com>
>
> Tested-by: Daniel Scally <djrscally@gmail.com>
Thanks!
> > Dan, feel free to incorporate this into your series.
> Thanks! I'll add it at the beginning so I can include this header in
> cio2-bridge.h, with my tags added too I guess
Right, please go ahead!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-03 14:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-30 20:44 [PATCH v1] media: ipu3-cio2: Add headers that ipu3-cio2.h is direct user of Andy Shevchenko
2021-01-03 0:11 ` Daniel Scally
2021-01-03 14:45 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).