Re: [PATCH v2 13/15] dt-binding: display: bcm2711-hdmi: Add CEC and hotplug interrupts

Rob Herring
2021-02-18T16:59:56Z

On Mon, Feb 1, 2021 at 12:56 PM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, Jan 11, 2021 at 8:27 AM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > The CEC and hotplug interrupts were missing when that binding was
> > introduced, let's add them in now that we've figured out how it works.
> >
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> > ---
> > .../bindings/display/brcm,bcm2711-hdmi.yaml | 20 ++++++++++++++++++-
> > 1 file changed, 19 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> > index 7ce06f9f9f8e..6e8ac910bdd8 100644
> > --- a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml
> > @@ -53,6 +53,24 @@ properties:
> > - const: audio
> > - const: cec
> >
> > + interrupts:
> > + items:
> > + - description: CEC TX interrupt
> > + - description: CEC RX interrupt
> > + - description: CEC stuck at low interrupt
> > + - description: Wake-up interrupt
> > + - description: Hotplug connected interrupt
> > + - description: Hotplug removed interrupt
> > +
> > + interrupt-names:
> > + items:
> > + - const: cec-tx
> > + - const: cec-rx
> > + - const: cec-low
> > + - const: wakeup
> > + - const: hpd-connected
> > + - const: hpd-removed
> > +
> > ddc:
> > allOf:
> > - $ref: /schemas/types.yaml#/definitions/phandle
> > @@ -90,7 +108,7 @@ required:
> > - resets
> > - ddc
> >
> > -additionalProperties: false
> > +unevaluatedProperties: false
>
> /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml:
> 'additionalProperties' is a required property
>
> And you missed the DT list, so no checks ran.

This is still failing in linux-next.

Rob