From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1898AC433E0 for ; Tue, 2 Feb 2021 20:32:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4D3164E2A for ; Tue, 2 Feb 2021 20:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232292AbhBBUc0 (ORCPT ); Tue, 2 Feb 2021 15:32:26 -0500 Received: from mga01.intel.com ([192.55.52.88]:64352 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231713AbhBBUby (ORCPT ); Tue, 2 Feb 2021 15:31:54 -0500 IronPort-SDR: xcD+GDjrmv6SPS0NiyXBo8CfOr6d61et6QNljHwmoBoDVrlqqCHhyEYcDrEgUPFtMjjML+gi00 adPNdo8aXL/A== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="199862100" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="199862100" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 12:30:28 -0800 IronPort-SDR: Mx4tMkIT+Do7OunarwgSuUOt9+EtmlhQ+WJrSglzwxIibEHchapRekDxwIxN07qc0OI2kkeVye sPQ8TSFxUKiA== X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="355440083" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 12:30:24 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 8C9482074F; Tue, 2 Feb 2021 22:30:22 +0200 (EET) Date: Tue, 2 Feb 2021 22:30:22 +0200 From: Sakari Ailus To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , linux-media , Dan Scally , Bingbu Cao , Yong Zhi Subject: Re: [PATCH 1/1] ipu3-cio2: Build bridge only if ACPI is enabled Message-ID: <20210202203022.GX32460@paasikivi.fi.intel.com> References: <20210202201440.10613-1-sakari.ailus@linux.intel.com> <070d3585-e21c-0bef-3740-d38fcd106f25@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <070d3585-e21c-0bef-3740-d38fcd106f25@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Feb 02, 2021 at 12:24:54PM -0800, Randy Dunlap wrote: > On 2/2/21 12:14 PM, Sakari Ailus wrote: > > ipu3-cio2-bridge uses several features of the ACPI framework that have no > > meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to > > the affected places, only build the bridge code if CONFIG_ACPI is enabled. > > > > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver") > > Signed-off-by: Sakari Ailus > > Reported-by: Randy Dunlap > Acked-by: Randy Dunlap # build-tested Thanks! I'll include this in a pull request to Mauro shortly. -- Sakari Ailus