From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>,
kernel@collabora.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>,
niklas.soderlund+renesas@ragnatech.se,
Helen Koike <helen.koike@collabora.com>,
Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
Hugues Fruchet <hugues.fruchet@st.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Yong Zhi <yong.zhi@intel.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Maxime Ripard <mripard@kernel.org>,
Robert Foss <robert.foss@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Ezequiel Garcia <ezequiel@collabora.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH 1/1] Documentation: media: Rework camera sensor, CSI-2, async doc syntax
Date: Mon, 8 Feb 2021 13:19:30 +0200 [thread overview]
Message-ID: <20210208111930.GR32460@paasikivi.fi.intel.com> (raw)
In-Reply-To: <6564b853-9631-8b76-9881-b39401fb93f9@ideasonboard.com>
Hi Kieran,
On Mon, Feb 08, 2021 at 11:08:45AM +0000, Kieran Bingham wrote:
> Hi Sakari,
>
> On 08/02/2021 10:44, Sakari Ailus wrote:
> > Improve syntax used for camera sensor, CSI-2 ReST and V4L2 async syntax
> > for better compatibility with newer Sphinx versions and use function
> > references where applicable.
> >
> > Not all internal references still work as kerneldoc doesn't appear to
> > support macros the way they are now used by v4l2-async.
> >
>
> Do you mean that with this some references will no longer
> highlight/link, where they used to? or that they no longer do, so this
> fixes them?
Some that should work don't while there's nothing wrong with the references
themselves. In particular the async subdev helpers that are now based on
macros are affected. This requires some more investigation and quite
possibly a kerneldoc change.
>
> The changes below look consistent and intentional though:
>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Thanks!
--
Regards,
Sakari Ailus
prev parent reply other threads:[~2021-02-08 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 10:44 [PATCH 1/1] Documentation: media: Rework camera sensor, CSI-2, async doc syntax Sakari Ailus
2021-02-08 11:08 ` Kieran Bingham
2021-02-08 11:19 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208111930.GR32460@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kernel@collabora.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=p.zabel@pengutronix.de \
--cc=robert.foss@linaro.org \
--cc=s.nawrocki@samsung.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox