From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: kbuild-all@lists.01.org, ezequiel@collabora.com
Subject: Re: [PATCH 1/1] v4l: async, fwnode: Improve module organisation
Date: Wed, 10 Mar 2021 12:15:21 +0800 [thread overview]
Message-ID: <202103101208.UvKcbzeS-lkp@intel.com> (raw)
In-Reply-To: <20210308100256.26270-1-sakari.ailus@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 10095 bytes --]
Hi Sakari,
I love your patch! Yet something to improve:
[auto build test ERROR on v5.12-rc2]
[cannot apply to linuxtv-media/master tegra/for-next next-20210309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-async-fwnode-Improve-module-organisation/20210308-180511
base: a38fd8748464831584a19438cbb3082b5a2dab15
config: x86_64-randconfig-a002-20200405 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/bc53c52b3ccb2fb944e8ffde8557129640fb2781
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sakari-Ailus/v4l-async-fwnode-Improve-module-organisation/20210308-180511
git checkout bc53c52b3ccb2fb944e8ffde8557129640fb2781
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
ld: warning: orphan section `.data..decrypted' from `arch/x86/kernel/cpu/vmware.o' being placed in section `.data..decrypted'
ld: warning: orphan section `.data..decrypted' from `arch/x86/kernel/kvm.o' being placed in section `.data..decrypted'
ld: drivers/media/i2c/adv7343.o: in function `adv7343_remove':
>> drivers/media/i2c/adv7343.c:500: undefined reference to `v4l2_async_unregister_subdev'
ld: drivers/media/i2c/adv7343.o: in function `adv7343_probe':
>> drivers/media/i2c/adv7343.c:486: undefined reference to `v4l2_async_register_subdev'
ld: drivers/media/i2c/max2175.o: in function `max2175_remove':
>> drivers/media/i2c/max2175.c:1413: undefined reference to `v4l2_async_unregister_subdev'
ld: drivers/media/i2c/max2175.o: in function `max2175_probe':
>> drivers/media/i2c/max2175.c:1382: undefined reference to `v4l2_async_register_subdev'
>> ld: drivers/media/i2c/max2175.c:1400: undefined reference to `v4l2_async_unregister_subdev'
vim +500 drivers/media/i2c/adv7343.c
187d42d6da62aa drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-07-20 430
e671499303e4c0 drivers/media/i2c/adv7343.c Kieran Bingham 2019-07-10 431 static int adv7343_probe(struct i2c_client *client)
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 432 {
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 433 struct adv7343_state *state;
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 434 int err;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 435
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 436 if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA))
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 437 return -ENODEV;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 438
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 439 v4l_info(client, "chip found @ 0x%x (%s)\n",
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 440 client->addr << 1, client->adapter->name);
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 441
c7a857a09f1f00 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-01-03 442 state = devm_kzalloc(&client->dev, sizeof(struct adv7343_state),
c7a857a09f1f00 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-01-03 443 GFP_KERNEL);
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 444 if (state == NULL)
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 445 return -ENOMEM;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 446
0b302d88534f08 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-01-22 447 /* Copy board specific information here */
187d42d6da62aa drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-07-20 448 state->pdata = adv7343_get_pdata(client);
0b302d88534f08 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-01-22 449
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 450 state->reg00 = 0x80;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 451 state->reg01 = 0x00;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 452 state->reg02 = 0x20;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 453 state->reg35 = 0x00;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 454 state->reg80 = ADV7343_SD_MODE_REG1_DEFAULT;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 455 state->reg82 = ADV7343_SD_MODE_REG2_DEFAULT;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 456
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 457 state->output = ADV7343_COMPOSITE_ID;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 458 state->std = V4L2_STD_NTSC;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 459
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 460 v4l2_i2c_subdev_init(&state->sd, client, &adv7343_ops);
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 461
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 462 v4l2_ctrl_handler_init(&state->hdl, 2);
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 463 v4l2_ctrl_new_std(&state->hdl, &adv7343_ctrl_ops,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 464 V4L2_CID_BRIGHTNESS, ADV7343_BRIGHTNESS_MIN,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 465 ADV7343_BRIGHTNESS_MAX, 1,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 466 ADV7343_BRIGHTNESS_DEF);
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 467 v4l2_ctrl_new_std(&state->hdl, &adv7343_ctrl_ops,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 468 V4L2_CID_HUE, ADV7343_HUE_MIN,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 469 ADV7343_HUE_MAX, 1,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 470 ADV7343_HUE_DEF);
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 471 v4l2_ctrl_new_std(&state->hdl, &adv7343_ctrl_ops,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 472 V4L2_CID_GAIN, ADV7343_GAIN_MIN,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 473 ADV7343_GAIN_MAX, 1,
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 474 ADV7343_GAIN_DEF);
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 475 state->sd.ctrl_handler = &state->hdl;
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 476 if (state->hdl.error) {
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 477 err = state->hdl.error;
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 478 goto done;
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 479 }
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 480 v4l2_ctrl_handler_setup(&state->hdl);
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 481
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 482 err = adv7343_initialize(&state->sd);
c7a857a09f1f00 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-01-03 483 if (err)
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 484 goto done;
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 485
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 @486 err = v4l2_async_register_subdev(&state->sd);
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 487
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 488 done:
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 489 if (err < 0)
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 490 v4l2_ctrl_handler_free(&state->hdl);
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 491
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 492 return err;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 493 }
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 494
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 495 static int adv7343_remove(struct i2c_client *client)
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 496 {
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 497 struct v4l2_subdev *sd = i2c_get_clientdata(client);
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 498 struct adv7343_state *state = to_state(sd);
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 499
6555cfc5e7f808 drivers/media/i2c/adv7343.c Lad, Prabhakar 2013-06-22 @500 v4l2_async_unregister_subdev(&state->sd);
ceed52d67e1cf7 drivers/media/video/adv7343.c Hans Verkuil 2010-12-12 501 v4l2_ctrl_handler_free(&state->hdl);
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 502
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 503 return 0;
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 504 }
06e61f8d5f5df6 drivers/media/video/adv7343.c Chaithrika U S 2009-05-07 505
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34770 bytes --]
prev parent reply other threads:[~2021-03-10 4:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 10:02 [PATCH 1/1] v4l: async, fwnode: Improve module organisation Sakari Ailus
2021-03-08 19:01 ` Ezequiel Garcia
2021-03-09 10:03 ` Sakari Ailus
2021-03-09 12:22 ` Ezequiel Garcia
2021-03-09 22:21 ` Sakari Ailus
2021-03-12 14:50 ` Ezequiel Garcia
2021-03-12 16:40 ` Sakari Ailus
2021-03-10 4:15 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103101208.UvKcbzeS-lkp@intel.com \
--to=lkp@intel.com \
--cc=ezequiel@collabora.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox