From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ricardo Ribalda <ribalda@chromium.org>,
Tomasz Figa <tfiga@chromium.org>,
linux-media <linux-media@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: fix GFP_ flags in uvc_submit_urb()
Date: Fri, 19 Mar 2021 18:07:02 +0300 [thread overview]
Message-ID: <20210319150702.GJ2087@kadam> (raw)
In-Reply-To: <CAPybu_1tZgCY6NKnbH+MovHGNEUzGeN=4oF-dG407H0wQ7oSWA@mail.gmail.com>
On Fri, Mar 19, 2021 at 03:57:44PM +0100, Ricardo Ribalda Delgado wrote:
> Hi Dan
>
> On Fri, Mar 19, 2021 at 3:48 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > The uvc_submit_urb() function is supposed to use the passed in GFP_
> > flags but this code accidentally uses GFP_KERNEL instead. Some of
> > the callers are passing GFP_ATOMIC so presumably this can lead to
> > sleeping in atomic context.
> >
> > Fixes: b20f917f84e6 ("media: uvcvideo: Use dma_alloc_noncontiguous API")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I reported the same issue just some minutes ago. Christoph has already
> fixed the patch in his tree.
>
> Where did you get the patchset? from next? from linus? or directly
> from Chirstoph tree?
From linux-next. I'm not sure if it was from yesterday's linux-next or
from a couple days ago.
regards,
dan carpenter
prev parent reply other threads:[~2021-03-19 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 14:47 [PATCH] media: uvcvideo: fix GFP_ flags in uvc_submit_urb() Dan Carpenter
2021-03-19 14:57 ` Ricardo Ribalda Delgado
2021-03-19 15:07 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319150702.GJ2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=ricardo.ribalda@gmail.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox