* [PATCH] media: rkvdec: Remove of_match_ptr()
@ 2021-03-20 12:21 Fabio Estevam
2021-03-20 16:58 ` Ezequiel Garcia
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2021-03-20 12:21 UTC (permalink / raw)
To: hverkuil
Cc: boris.brezillon, ezequiel, linux-media, Fabio Estevam,
kernel test robot
When building with CONFIG_OF not set, the following clang
build warning is seen:
>> drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable 'of_rkvdec_match' [-Wunused-const-variable]
Fix the warning by removing the unnecessary of_match_ptr().
Reported-by: kernel test robot <lkp@intel.com>
Fixes: cd33c830448b ("media: rkvdec: Add the rkvdec driver")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/staging/media/rkvdec/rkvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
index 225eeca73356..0ff013c1fc38 100644
--- a/drivers/staging/media/rkvdec/rkvdec.c
+++ b/drivers/staging/media/rkvdec/rkvdec.c
@@ -1092,7 +1092,7 @@ static struct platform_driver rkvdec_driver = {
.remove = rkvdec_remove,
.driver = {
.name = "rkvdec",
- .of_match_table = of_match_ptr(of_rkvdec_match),
+ .of_match_table = of_rkvdec_match,
.pm = &rkvdec_pm_ops,
},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: rkvdec: Remove of_match_ptr()
2021-03-20 12:21 [PATCH] media: rkvdec: Remove of_match_ptr() Fabio Estevam
@ 2021-03-20 16:58 ` Ezequiel Garcia
0 siblings, 0 replies; 2+ messages in thread
From: Ezequiel Garcia @ 2021-03-20 16:58 UTC (permalink / raw)
To: Fabio Estevam, hverkuil; +Cc: boris.brezillon, linux-media, kernel test robot
On Sat, 2021-03-20 at 09:21 -0300, Fabio Estevam wrote:
> When building with CONFIG_OF not set, the following clang
> build warning is seen:
>
> > > drivers/staging/media/rkvdec/rkvdec.c:967:34: warning: unused variable 'of_rkvdec_match' [-Wunused-const-variable]
>
> Fix the warning by removing the unnecessary of_match_ptr().
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: cd33c830448b ("media: rkvdec: Add the rkvdec driver")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index 225eeca73356..0ff013c1fc38 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -1092,7 +1092,7 @@ static struct platform_driver rkvdec_driver = {
> .remove = rkvdec_remove,
> .driver = {
> .name = "rkvdec",
> - .of_match_table = of_match_ptr(of_rkvdec_match),
> + .of_match_table = of_rkvdec_match,
> .pm = &rkvdec_pm_ops,
> },
> };
Looks good.
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Thanks,
Ezequiel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-20 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-20 12:21 [PATCH] media: rkvdec: Remove of_match_ptr() Fabio Estevam
2021-03-20 16:58 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox