Re: [PATCH 09/10] media: Keem Bay Camera: Add metadata video node

['Sakari Ailus' <sakari.ailus@linux.intel.com>]

Hi Martina,

On Fri, Apr 09, 2021 at 03:19:20PM +0100, Martina Krasteva wrote:
> Hi Sakari,
> 
> Thank you for the review :)

You're welcome!

...

> > > +static const struct kmb_vpu_warp_params warp_default = {
> > > +	.type = 0,
> > > +	.relative = 0,
> > > +	.format = 0,
> > > +	.position = 0,
> > > +	.reserved = { 0 },
> > > +	.width = 8,
> > > +	.height = 4,
> > > +	.stride = 128,
> > > +	.enable = 0,
> > > +	.matrix = {1, 0, 0, 0, 1, 0, 0, 0, 1},
> > > +	.mode = 1,
> > > +	.values = {0, 128, 128},
> > 
> > These seem to be default values for the parameters.
> > 
> > Are any of the values above dependent on the image sizes, for instance?
> > 

> Some of them might be resolution dependent, I need to double check. How
> should we handle the defaults that are dependent? Should we disable them
> or initialize with 0

Good question. I hope there aren't any, but if there are, the values could
be need to be either derived from the V4L2 mbus or pixel format
configuration somehow, i.e. they'd be zeros here.

-- 
Kind regards,

Sakari Ailus