From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Andrey Konovalov" <andrey.konovalov@linaro.org>,
"Jacopo Mondi" <jacopo@jmondi.org>
Subject: [PATCH v3 5/6] media: rcar-vin: Remove explicit device availability check
Date: Thu, 24 Jun 2021 11:40:45 +0300 [thread overview]
Message-ID: <20210624084046.13136-6-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20210624084046.13136-1-sakari.ailus@linux.intel.com>
From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
The fwnode is retrieved using fwnode_graph_get_endpoint_by_id() without
the FWNODE_GRAPH_DEVICE_DISABLED flag set. So there is no need to
explicitly check if the fwnode is available as it always will be when
the check is performed, remove it.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
---
drivers/media/platform/rcar-vin/rcar-core.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
index 3b7052ff7117..a24aeda37e74 100644
--- a/drivers/media/platform/rcar-vin/rcar-core.c
+++ b/drivers/media/platform/rcar-vin/rcar-core.c
@@ -834,13 +834,6 @@ static int rvin_mc_parse_of(struct rvin_dev *vin, unsigned int id)
goto out;
}
- if (!of_device_is_available(to_of_node(fwnode))) {
- vin_dbg(vin, "OF device %pOF disabled, ignoring\n",
- to_of_node(fwnode));
- ret = -ENOTCONN;
- goto out;
- }
-
asd = v4l2_async_nf_add_fwnode(&vin->group->notifier, fwnode,
struct v4l2_async_subdev);
if (IS_ERR(asd)) {
--
2.30.2
next prev parent reply other threads:[~2021-06-24 8:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 8:40 [PATCH v3 0/6] V4L2 driver documentation, v4l2-async improvements Sakari Ailus
2021-06-24 8:40 ` [PATCH v3 1/6] Documentation: media: Improve camera sensor documentation Sakari Ailus
2021-07-27 10:54 ` Kieran Bingham
2021-07-27 11:27 ` Sakari Ailus
2021-06-24 8:40 ` [PATCH v3 2/6] Documentation: media: Fix v4l2-async kerneldoc syntax Sakari Ailus
2021-07-27 12:19 ` Kieran Bingham
2021-06-24 8:40 ` [PATCH v3 3/6] v4l: async: Rename async nf functions, clean up long lines Sakari Ailus
2021-06-24 9:18 ` Rui Miguel Silva
2021-07-26 15:48 ` [PATCH v3.1 " Sakari Ailus
2021-08-02 5:19 ` [PATCH v3.2 " Sakari Ailus
2021-08-02 19:19 ` [PATCH v3.3 " Sakari Ailus
2021-07-27 12:41 ` [PATCH v3 " Kieran Bingham
2021-07-27 12:53 ` Sakari Ailus
2021-06-24 8:40 ` [PATCH v3 4/6] media: v4l2-fwnode: Simplify v4l2_async_nf_parse_fwnode_endpoints() Sakari Ailus
2021-07-27 12:45 ` Kieran Bingham
2021-06-24 8:40 ` Sakari Ailus [this message]
2021-07-27 12:53 ` [PATCH v3 5/6] media: rcar-vin: Remove explicit device availability check Kieran Bingham
2021-06-24 8:40 ` [PATCH v3 6/6] Documentation: v4l: Fix V4L2_CID_PIXEL_RATE documentation Sakari Ailus
2021-07-27 12:54 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624084046.13136-6-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andrey.konovalov@linaro.org \
--cc=jacopo@jmondi.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox