Re: [PATCH v3 3/6] v4l: async: Rename async nf functions, clean up long lines

[Sakari Ailus <sakari.ailus@linux.intel.com>]

On Tue, Jul 27, 2021 at 01:41:26PM +0100, Kieran Bingham wrote:
> Hi Sakari,
> 
> On 24/06/2021 09:40, Sakari Ailus wrote:
> > Rename V4L2 async notifier functions, replacing "notifier" with "nf" and
> > removing "_subdev" at the end of the function names adding subdevs as you
> > can only add subdevs to a notifier. Also wrap and otherwise clean up long
> > lines.
> 
> Removing _subdev sounds reasonable, I have a slight distaste on the 'nf'
> shorthand, as it's not very clear. I don't instantly associate the 'nf'
> as a 'notifier' and started looking for an acronmym definition ...
> 
> 
> But taste shouldn't necessarily block that, and it does shorten lines on
> some ... really long function names ...
> 
> 
> I see below one local variable is 'ntf' and that 't' helps bring in a
> bit of context vs nf ... but I don't think that's particilarly worth
> changing this series.
> 
> I can't spot anything else, so
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Thanks.

"Nf" always comes with "async_" before it, so I don't think it should
really leave much room for interpretation. The more letters you add the
less is the effect of the rename, the main reason for which was to shorten
the names.

-- 
Sakari Ailus