Re: [PATCH v2 08/12] media: i2c: Add hblank control to ov8865

Sakari Ailus
2021-08-10T14:29:43Z

Hi Daniel,

On Mon, Aug 09, 2021 at 11:58:41PM +0100, Daniel Scally wrote:
> @@ -2542,6 +2544,13 @@ static int ov8865_ctrls_init(struct ov8865_sensor *sensor)
> 0, 0, ov8865_test_pattern_menu);
>
> /* Blanking */
> + hblank = mode->hts < mode->output_size_x ? 0 : mode->hts - mode->output_size_x;

Is the result in relation with the analogue crop size? Based on the above
it wouldn't seem like that.

> + ctrls->hblank = v4l2_ctrl_new_std(handler, ops, V4L2_CID_HBLANK, hblank,
> + hblank, 1, hblank);
> +
> + if (ctrls->hblank)
> + ctrls->hblank->flags |= V4L2_CTRL_FLAG_READ_ONLY;
> +
> vblank_max = OV8865_TIMING_MAX_VTS - mode->output_size_y;
> vblank_def = mode->vts - mode->output_size_y;
> ctrls->vblank = v4l2_ctrl_new_std(handler, ops, V4L2_CID_VBLANK,

--
Sakari Ailus