Re: [PATCH v2 04/12] media: i2c: Support 19.2MHz input clock in ov8865

Daniel Scally
2021-08-10T21:46:45Z

Hi Andy

On 10/08/2021 14:04, Andy Shevchenko wrote:
>> + ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency",
>> + &rate);
>> + if (!ret) {
> I'm wondering if something like
>
> ... rate = 0;
>
> fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency", &rate);
> if (rate > 0) {
>
> can be used.
Should be fine, and I agree that it makes the point of the check more
clear, thanks.