Re: [PATCH v2 05/12] media: i2c: Add .get_selection() support to ov8865

Laurent Pinchart
2021-08-25T08:04:20Z

On Wed, Aug 25, 2021 at 10:16:02AM +0300, Sakari Ailus wrote:
> On Wed, Aug 25, 2021 at 12:17:15AM +0100, Daniel Scally wrote:
> > Hi Sakari - sorry delayed reply
> >
> > On 10/08/2021 14:38, Sakari Ailus wrote:
> > > Hi Daniel,
> > >
> > > On Mon, Aug 09, 2021 at 11:58:38PM +0100, Daniel Scally wrote:
> > >> The ov8865 driver's v4l2_subdev_pad_ops currently does not include
> > >> .get_selection() - add support for that callback.
> > > Could you use the same for .set_selection()? Even if it doesn't change
> > > anything.
> >
> > You mean do the same? Or use the same function?
>
> The same function. If the selection isn't changeable anyway, the
> functionality is the same for both.

Except that .s_selection() should return an error if you try to set the
bounds or default rectangles.

--
Regards,

Laurent Pinchart