From: Sean Young <sean@mess.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "kernel test robot" <lkp@intel.com>,
"Maíra Canal" <maira.canal@usp.br>,
mchehab@kernel.org, thierry.reding@gmail.com,
lee.jones@linaro.org, llvm@lists.linux.dev,
kbuild-all@lists.01.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v3] media: rc: pwm-ir-tx: Switch to atomic PWM API
Date: Wed, 27 Oct 2021 08:32:04 +0100 [thread overview]
Message-ID: <20211027073204.GA3978@gofer.mess.org> (raw)
In-Reply-To: <20211027061552.bb4fczniqp6b7amh@pengutronix.de>
On Wed, Oct 27, 2021 at 08:15:52AM +0200, Uwe Kleine-König wrote:
> On Wed, Oct 27, 2021 at 02:07:19PM +0800, kernel test robot wrote:
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> > >> ERROR: modpost: "__udivdi3" [drivers/media/rc/pwm-ir-tx.ko] undefined!
>
> This comes from the line:
>
> state.duty_cycle = DIV_ROUND_CLOSEST(pwm_ir->duty_cycle * state.period, 100);
>
> where DIV_ROUND_CLOSEST expands to a normal division but state.period is
> a u64. So this should use DIV64_U64_ROUND_CLOSEST I guess.
DIV64_U64_ROUND_CLOSEST is for dividing a u64 with a u64. We're dividing
by 100 here so this is not necessary.
It should use DIV_ROUND_CLOSEST_ULL, however it might be nicer to use:
pwm_set_relative_duty_cycle(&state, pwm_ir->duty_cycle, 100);
Thanks
Sean
next prev parent reply other threads:[~2021-10-27 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 10:33 [PATCH v3] media: rc: pwm-ir-tx: Switch to atomic PWM API Maíra Canal
2021-10-25 6:08 ` Uwe Kleine-König
2021-10-27 6:07 ` kernel test robot
2021-10-27 6:15 ` Uwe Kleine-König
2021-10-27 7:32 ` Sean Young [this message]
[not found] ` <CAH7FV3nb8K2qKgGZh-uMCk_BykWJ_sOb7K-jEhNjazYSiXdqbw@mail.gmail.com>
2021-10-27 12:43 ` Maíra Canal
2021-10-27 12:48 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027073204.GA3978@gofer.mess.org \
--to=sean@mess.org \
--cc=kbuild-all@lists.01.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=maira.canal@usp.br \
--cc=mchehab@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox