From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linuxarm <linuxarm@huawei.com>,
mauro.chehab@huawei.com, Aditya Srivastava <yashsri421@gmail.com>,
Alex Dewar <alex.dewar90@gmail.com>,
Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>, Baokun Li <libaokun1@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Kaixu Xia <kaixuxia@tencent.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
Yang Li <abaci-bugfix@linux.alibaba.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 1/2] media: atomisp: better describe get_frame_info issues
Date: Tue, 2 Nov 2021 06:54:15 +0000 [thread overview]
Message-ID: <20211102065415.4850a80b@sal.lan> (raw)
In-Reply-To: <CAHp75VdaTEOaGhA43O1==Deg_0Ej_ZzOp8AX5NKZB5zegN42Pg@mail.gmail.com>
Em Fri, 29 Oct 2021 12:01:57 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> escreveu:
> > + switch (type) {
> > + case ATOMISP_CSS_VF_FRAME:
> > + *info = p_info.vf_output_info[0];
> > + dev_dbg(isp->dev, "getting vf frame info.\n");
> > + break;
> > + case ATOMISP_CSS_SECOND_VF_FRAME:
> > + *info = p_info.vf_output_info[1];
> > + dev_dbg(isp->dev, "getting second vf frame info.\n");
> > + break;
> > + case ATOMISP_CSS_OUTPUT_FRAME:
> > + *info = p_info.output_info[0];
> > + dev_dbg(isp->dev, "getting main frame info.\n");
> > + break;
> > + case ATOMISP_CSS_SECOND_OUTPUT_FRAME:
> > + *info = p_info.output_info[1];
> > + dev_dbg(isp->dev, "getting second main frame info.\n");
> > + break;
> > + case ATOMISP_CSS_RAW_FRAME:
> > + *info = p_info.raw_output_info;
> > + dev_dbg(isp->dev, "getting raw frame info.\n");
>
> Can we get break; here followed by default case?
Surely. I'll do such change on a separate patch.
Regards,
Mauro
prev parent reply other threads:[~2021-11-02 6:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 8:49 [PATCH 1/2] media: atomisp: better describe get_frame_info issues Mauro Carvalho Chehab
2021-10-29 8:49 ` [PATCH 2/2] media: atomisp: set default mode Mauro Carvalho Chehab
2021-10-29 19:27 ` Mauro Carvalho Chehab
2021-10-29 9:01 ` [PATCH 1/2] media: atomisp: better describe get_frame_info issues Andy Shevchenko
2021-11-02 6:54 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102065415.4850a80b@sal.lan \
--to=mchehab+huawei@kernel.org \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=alex.dewar90@gmail.com \
--cc=alinesantanacordeiro@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kaixuxia@tencent.com \
--cc=kitakar@gmail.com \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox