Re: [PATCH v3] drm/amdgpu: introduce new amdgpu_fence object to indicate the job embedded fence

[kernel test robot <lkp@intel.com>]

Hi Huang,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm/drm-next]
[also build test WARNING on drm-intel/for-linux-next drm-tip/drm-tip v5.16-rc5 next-20211214]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Huang-Rui/drm-amdgpu-introduce-new-amdgpu_fence-object-to-indicate-the-job-embedded-fence/20211215-143731
base:   git://anongit.freedesktop.org/drm/drm drm-next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20211215/202112152115.sqAqnvG7-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/a47becf231b123760625c45242e89f5e5b5b4915
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Huang-Rui/drm-amdgpu-introduce-new-amdgpu_fence-object-to-indicate-the-job-embedded-fence/20211215-143731
        git checkout a47becf231b123760625c45242e89f5e5b5b4915
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/amd/amdgpu/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:631: warning: expecting prototype for amdgpu_fence_clear_job_fences(). Prototype was for amdgpu_fence_driver_clear_job_fences() instead


vim +631 drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c

   623	
   624	/**
   625	 * amdgpu_fence_clear_job_fences - clear job embedded fences of ring
   626	 *
   627	 * @ring: fence of the ring to be cleared
   628	 *
   629	 */
   630	void amdgpu_fence_driver_clear_job_fences(struct amdgpu_ring *ring)
 > 631	{
   632		int i;
   633		struct dma_fence *old, **ptr;
   634	
   635		for (i = 0; i <= ring->fence_drv.num_fences_mask; i++) {
   636			ptr = &ring->fence_drv.fences[i];
   637			old = rcu_dereference_protected(*ptr, 1);
   638			if (old && old->ops == &amdgpu_job_fence_ops)
   639				RCU_INIT_POINTER(*ptr, NULL);
   640		}
   641	}
   642	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org