* [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
@ 2022-01-06 21:45 Christophe JAILLET
2022-01-06 21:50 ` [PATCH 04/16] media: " Christophe JAILLET
` (5 more replies)
0 siblings, 6 replies; 16+ messages in thread
From: Christophe JAILLET @ 2022-01-06 21:45 UTC (permalink / raw)
To: arnd, hch, akpm, rth, ink, mattst88, mpe, benh, paulus, davem,
airlied, vkoul, hao.wu, trix, mdf, yilun.xu, awalls, mchehab,
sathya.prakash, sreekanth.reddy, suganath-prabu.subramani,
mporter, alex.bou9, bhelgaas
Cc: linux-alpha, linuxppc-dev, sparclinux, dmaengine, linux-fpga,
linux-media, MPT-FusionLinux.pdl, linux-scsi, linux-pci,
linux-kernel, kernel-janitors, Christophe JAILLET
This serie axes all the remaining usages of the deprecated "pci-dma-compat.h"
API.
All these patches have already been posted.
They have been generated with a coccinelle script.
The tricky parts are patches that use dma_alloc_coherent() because the correct
GFP flag has to be used in place of the previous embedded GFP_ATOMIC.
Patches 1-3 are already Reviewed. References to the corresponding mail is
given below the ---
Patch 1-2,4-10 are just generated from the coccinelle script. Only too long
lines have been hand modified. dma_alloc_coherent() modification are NOT part
of these patches.
Patch 3 also includes some 'dma_set_mask_and_coherent()' instead of
'pci_set_dma_mask()/pci_set_consistent_dma_mask()'.
I've left this additional modification because it was reviewed with it.
Patch 10-15 are the tricky parts. Explanation of which GFP flag is the right one
is given in each patch. It has been divided in several patches to ease review.
Patch 15 is the only one I'm slighly unsure with. The old code was using a
GFP_USER flag in the function. I'm not familiar with it.
I *guess* that GFP_KERNEL is fine, but maybe it should also be GFP_USER or left
as GFP_ATOMIC so that nothing is changed.
Patch 16 is the last step that remove "pci-dma-compat.h" and its only usage.
All patches, exept 1-2,6 that are architecture specific, have been compile tested.
After all that, a few rst files, 1 or 2 strings in error messages and some
error branching labels should still need some attention.
This is some minor issues.
Only the cover letter is sent to every one. Each patch is sent to the
corresponding maintainer(s) + Andrew Morton, Christoph Hellwig and Arnd Bergmann.
Best regards.
Christophe JAILLET (16):
alpha: Remove usage of the deprecated "pci-dma-compat.h" API
floppy: Remove usage of the deprecated "pci-dma-compat.h" API
fpga: dfl: pci: Remove usage of the deprecated "pci-dma-compat.h" API
media: Remove usage of the deprecated "pci-dma-compat.h" API
agp/intel: Remove usage of the deprecated "pci-dma-compat.h" API
sparc: Remove usage of the deprecated "pci-dma-compat.h" API
dmaengine: pch_dma: Remove usage of the deprecated "pci-dma-compat.h"
API
rapidio/tsi721: Remove usage of the deprecated "pci-dma-compat.h" API
media: v4l2-pci-skeleton: Remove usage of the deprecated
"pci-dma-compat.h" API
scsi: message: fusion: Remove usage of the deprecated
"pci-dma-compat.h" API
scsi: mptbase: Use dma_alloc_coherent() in 'mpt_alloc_fw_memory()'
scsi: mptbase: Use dma_alloc_coherent()
scsi: mptsas: Use dma_alloc_coherent() in
mptsas_exp_repmanufacture_info()
scsi: mptsas: Use dma_alloc_coherent()
scsi: mptctl: Use dma_alloc_coherent()
PCI: Remove usage of the deprecated "pci-dma-compat.h" API
arch/alpha/include/asm/floppy.h | 7 +-
arch/alpha/kernel/pci_iommu.c | 12 +--
arch/powerpc/include/asm/floppy.h | 8 +-
arch/sparc/kernel/ioport.c | 2 +-
drivers/char/agp/intel-gtt.c | 26 ++---
drivers/dma/pch_dma.c | 2 +-
drivers/fpga/dfl-pci.c | 14 +--
drivers/media/pci/cx18/cx18-queue.h | 6 +-
drivers/media/pci/ivtv/ivtv-queue.h | 25 +++--
drivers/media/pci/ivtv/ivtv-udma.h | 8 +-
drivers/message/fusion/mptbase.c | 149 ++++++++++++++++------------
drivers/message/fusion/mptctl.c | 82 +++++++++------
drivers/message/fusion/mptlan.c | 90 +++++++++--------
drivers/message/fusion/mptsas.c | 94 +++++++++---------
drivers/rapidio/devices/tsi721.c | 8 +-
include/linux/pci-dma-compat.h | 129 ------------------------
include/linux/pci.h | 3 -
samples/v4l/v4l2-pci-skeleton.c | 2 +-
18 files changed, 289 insertions(+), 378 deletions(-)
delete mode 100644 include/linux/pci-dma-compat.h
--
2.32.0
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 04/16] media: Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-06 21:45 [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
@ 2022-01-06 21:50 ` Christophe JAILLET
2022-01-07 0:51 ` Arnd Bergmann
2022-01-10 8:44 ` Christoph Hellwig
2022-01-10 15:35 ` [PATCH 00/16] " Martin K. Petersen
` (4 subsequent siblings)
5 siblings, 2 replies; 16+ messages in thread
From: Christophe JAILLET @ 2022-01-06 21:50 UTC (permalink / raw)
To: arnd, hch, akpm, awalls, mchehab
Cc: linux-media, linux-kernel, kernel-janitors, Christophe JAILLET
In [1], Christoph Hellwig has proposed to remove the wrappers in
include/linux/pci-dma-compat.h.
Some reasons why this API should be removed have been given by Julia
Lawall in [2].
A coccinelle script has been used to perform the needed transformation.
It can be found in [3].
[1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/
[2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/
[3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/media/pci/cx18/cx18-queue.h | 6 +++---
drivers/media/pci/ivtv/ivtv-queue.h | 25 ++++++++++++++-----------
drivers/media/pci/ivtv/ivtv-udma.h | 8 ++++----
3 files changed, 21 insertions(+), 18 deletions(-)
diff --git a/drivers/media/pci/cx18/cx18-queue.h b/drivers/media/pci/cx18/cx18-queue.h
index e0a34bd6539e..26f2097c0496 100644
--- a/drivers/media/pci/cx18/cx18-queue.h
+++ b/drivers/media/pci/cx18/cx18-queue.h
@@ -15,15 +15,15 @@
static inline void cx18_buf_sync_for_cpu(struct cx18_stream *s,
struct cx18_buffer *buf)
{
- pci_dma_sync_single_for_cpu(s->cx->pci_dev, buf->dma_handle,
+ dma_sync_single_for_cpu(&s->cx->pci_dev->dev, buf->dma_handle,
s->buf_size, s->dma);
}
static inline void cx18_buf_sync_for_device(struct cx18_stream *s,
struct cx18_buffer *buf)
{
- pci_dma_sync_single_for_device(s->cx->pci_dev, buf->dma_handle,
- s->buf_size, s->dma);
+ dma_sync_single_for_device(&s->cx->pci_dev->dev, buf->dma_handle,
+ s->buf_size, s->dma);
}
void _cx18_mdl_sync_for_device(struct cx18_stream *s, struct cx18_mdl *mdl);
diff --git a/drivers/media/pci/ivtv/ivtv-queue.h b/drivers/media/pci/ivtv/ivtv-queue.h
index 586b0bf63c26..b8fc2669a358 100644
--- a/drivers/media/pci/ivtv/ivtv-queue.h
+++ b/drivers/media/pci/ivtv/ivtv-queue.h
@@ -17,20 +17,20 @@
static inline int ivtv_might_use_pio(struct ivtv_stream *s)
{
- return s->dma == PCI_DMA_NONE || (SLICED_VBI_PIO && s->type == IVTV_ENC_STREAM_TYPE_VBI);
+ return s->dma == DMA_NONE || (SLICED_VBI_PIO && s->type == IVTV_ENC_STREAM_TYPE_VBI);
}
static inline int ivtv_use_pio(struct ivtv_stream *s)
{
struct ivtv *itv = s->itv;
- return s->dma == PCI_DMA_NONE ||
+ return s->dma == DMA_NONE ||
(SLICED_VBI_PIO && s->type == IVTV_ENC_STREAM_TYPE_VBI && itv->vbi.sliced_in->service_set);
}
static inline int ivtv_might_use_dma(struct ivtv_stream *s)
{
- return s->dma != PCI_DMA_NONE;
+ return s->dma != DMA_NONE;
}
static inline int ivtv_use_dma(struct ivtv_stream *s)
@@ -41,15 +41,16 @@ static inline int ivtv_use_dma(struct ivtv_stream *s)
static inline void ivtv_buf_sync_for_cpu(struct ivtv_stream *s, struct ivtv_buffer *buf)
{
if (ivtv_use_dma(s))
- pci_dma_sync_single_for_cpu(s->itv->pdev, buf->dma_handle,
- s->buf_size + 256, s->dma);
+ dma_sync_single_for_cpu(&s->itv->pdev->dev, buf->dma_handle,
+ s->buf_size + 256, s->dma);
}
static inline void ivtv_buf_sync_for_device(struct ivtv_stream *s, struct ivtv_buffer *buf)
{
if (ivtv_use_dma(s))
- pci_dma_sync_single_for_device(s->itv->pdev, buf->dma_handle,
- s->buf_size + 256, s->dma);
+ dma_sync_single_for_device(&s->itv->pdev->dev,
+ buf->dma_handle, s->buf_size + 256,
+ s->dma);
}
int ivtv_buf_copy_from_user(struct ivtv_stream *s, struct ivtv_buffer *buf, const char __user *src, int copybytes);
@@ -70,15 +71,17 @@ void ivtv_stream_free(struct ivtv_stream *s);
static inline void ivtv_stream_sync_for_cpu(struct ivtv_stream *s)
{
if (ivtv_use_dma(s))
- pci_dma_sync_single_for_cpu(s->itv->pdev, s->sg_handle,
- sizeof(struct ivtv_sg_element), PCI_DMA_TODEVICE);
+ dma_sync_single_for_cpu(&s->itv->pdev->dev, s->sg_handle,
+ sizeof(struct ivtv_sg_element),
+ DMA_TO_DEVICE);
}
static inline void ivtv_stream_sync_for_device(struct ivtv_stream *s)
{
if (ivtv_use_dma(s))
- pci_dma_sync_single_for_device(s->itv->pdev, s->sg_handle,
- sizeof(struct ivtv_sg_element), PCI_DMA_TODEVICE);
+ dma_sync_single_for_device(&s->itv->pdev->dev, s->sg_handle,
+ sizeof(struct ivtv_sg_element),
+ DMA_TO_DEVICE);
}
#endif
diff --git a/drivers/media/pci/ivtv/ivtv-udma.h b/drivers/media/pci/ivtv/ivtv-udma.h
index 0eef104e03b9..12b9426b2db2 100644
--- a/drivers/media/pci/ivtv/ivtv-udma.h
+++ b/drivers/media/pci/ivtv/ivtv-udma.h
@@ -23,14 +23,14 @@ void ivtv_udma_start(struct ivtv *itv);
static inline void ivtv_udma_sync_for_device(struct ivtv *itv)
{
- pci_dma_sync_single_for_device(itv->pdev, itv->udma.SG_handle,
- sizeof(itv->udma.SGarray), PCI_DMA_TODEVICE);
+ dma_sync_single_for_device(&itv->pdev->dev, itv->udma.SG_handle,
+ sizeof(itv->udma.SGarray), DMA_TO_DEVICE);
}
static inline void ivtv_udma_sync_for_cpu(struct ivtv *itv)
{
- pci_dma_sync_single_for_cpu(itv->pdev, itv->udma.SG_handle,
- sizeof(itv->udma.SGarray), PCI_DMA_TODEVICE);
+ dma_sync_single_for_cpu(&itv->pdev->dev, itv->udma.SG_handle,
+ sizeof(itv->udma.SGarray), DMA_TO_DEVICE);
}
#endif
--
2.32.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 04/16] media: Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-06 21:50 ` [PATCH 04/16] media: " Christophe JAILLET
@ 2022-01-07 0:51 ` Arnd Bergmann
2022-01-07 7:10 ` Mauro Carvalho Chehab
2022-01-10 8:44 ` Christoph Hellwig
1 sibling, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2022-01-07 0:51 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Arnd Bergmann, Christoph Hellwig, Andrew Morton, awalls,
Mauro Carvalho Chehab, Linux Media Mailing List,
Linux Kernel Mailing List, kernel-janitors
On Thu, Jan 6, 2022 at 4:50 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> In [1], Christoph Hellwig has proposed to remove the wrappers in
> include/linux/pci-dma-compat.h.
>
> Some reasons why this API should be removed have been given by Julia
> Lawall in [2].
>
> A coccinelle script has been used to perform the needed transformation.
> It can be found in [3].
>
> [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/
> [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/
> [3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Mauro, could you pick this up directly? It has no dependencies on the rest of
the series.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 04/16] media: Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-07 0:51 ` Arnd Bergmann
@ 2022-01-07 7:10 ` Mauro Carvalho Chehab
2022-02-18 13:11 ` Hans Verkuil
0 siblings, 1 reply; 16+ messages in thread
From: Mauro Carvalho Chehab @ 2022-01-07 7:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Christophe JAILLET, Christoph Hellwig, Andrew Morton, awalls,
Linux Media Mailing List, Linux Kernel Mailing List,
kernel-janitors
Em Thu, 6 Jan 2022 19:51:47 -0500
Arnd Bergmann <arnd@arndb.de> escreveu:
> On Thu, Jan 6, 2022 at 4:50 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> >
> > In [1], Christoph Hellwig has proposed to remove the wrappers in
> > include/linux/pci-dma-compat.h.
> >
> > Some reasons why this API should be removed have been given by Julia
> > Lawall in [2].
> >
> > A coccinelle script has been used to perform the needed transformation.
> > It can be found in [3].
> >
> > [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/
> > [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/
> > [3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> Mauro, could you pick this up directly? It has no dependencies on the rest of
> the series.
Sure, but I already closed the media merge window. If you prefer to
apply it directly via your tree, that would be OK for me as well.
If so, just let me know. On such case:
Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Regards,
Mauro
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 04/16] media: Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-06 21:50 ` [PATCH 04/16] media: " Christophe JAILLET
2022-01-07 0:51 ` Arnd Bergmann
@ 2022-01-10 8:44 ` Christoph Hellwig
1 sibling, 0 replies; 16+ messages in thread
From: Christoph Hellwig @ 2022-01-10 8:44 UTC (permalink / raw)
To: Christophe JAILLET
Cc: arnd, hch, akpm, awalls, mchehab, linux-media, linux-kernel,
kernel-janitors
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-06 21:45 [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
2022-01-06 21:50 ` [PATCH 04/16] media: " Christophe JAILLET
@ 2022-01-10 15:35 ` Martin K. Petersen
2022-01-19 4:06 ` Martin K. Petersen
` (3 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: Martin K. Petersen @ 2022-01-10 15:35 UTC (permalink / raw)
To: Christophe JAILLET
Cc: arnd, hch, akpm, rth, ink, mattst88, mpe, benh, paulus, davem,
airlied, vkoul, hao.wu, trix, mdf, yilun.xu, awalls, mchehab,
sathya.prakash, sreekanth.reddy, suganath-prabu.subramani,
mporter, alex.bou9, bhelgaas, linux-alpha, linuxppc-dev,
sparclinux, dmaengine, linux-fpga, linux-media,
MPT-FusionLinux.pdl, linux-scsi, linux-pci, linux-kernel,
kernel-janitors
Christophe,
> This serie axes all the remaining usages of the deprecated
> "pci-dma-compat.h" API.
Applied patches 10-15 to 5.17/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-06 21:45 [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
2022-01-06 21:50 ` [PATCH 04/16] media: " Christophe JAILLET
2022-01-10 15:35 ` [PATCH 00/16] " Martin K. Petersen
@ 2022-01-19 4:06 ` Martin K. Petersen
2022-01-25 19:28 ` Moritz Fischer
` (2 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: Martin K. Petersen @ 2022-01-19 4:06 UTC (permalink / raw)
To: sreekanth.reddy, mchehab, mdf, mpe, mporter, hch, bhelgaas,
airlied, Christophe JAILLET, benh, ink, davem, akpm, hao.wu,
vkoul, sathya.prakash, paulus, trix, arnd, yilun.xu,
suganath-prabu.subramani, alex.bou9, awalls, rth, mattst88
Cc: Martin K . Petersen, linux-kernel, linuxppc-dev, linux-alpha,
linux-fpga, MPT-FusionLinux.pdl, linux-media, sparclinux,
linux-pci, linux-scsi, dmaengine, kernel-janitors
On Thu, 6 Jan 2022 22:45:13 +0100, Christophe JAILLET wrote:
> This serie axes all the remaining usages of the deprecated "pci-dma-compat.h"
> API.
>
> All these patches have already been posted.
>
> They have been generated with a coccinelle script.
> The tricky parts are patches that use dma_alloc_coherent() because the correct
> GFP flag has to be used in place of the previous embedded GFP_ATOMIC.
>
> [...]
Applied to 5.17/scsi-queue, thanks!
[10/16] scsi: message: fusion: Remove usage of the deprecated "pci-dma-compat.h" API
https://git.kernel.org/mkp/scsi/c/b114dda6f2f1
[11/16] scsi: mptbase: Use dma_alloc_coherent() in 'mpt_alloc_fw_memory()'
https://git.kernel.org/mkp/scsi/c/2d50607260a6
[12/16] scsi: mptbase: Use dma_alloc_coherent()
https://git.kernel.org/mkp/scsi/c/5c5e6b6f61e0
[13/16] scsi: mptsas: Use dma_alloc_coherent() in mptsas_exp_repmanufacture_info()
https://git.kernel.org/mkp/scsi/c/7a960b3a5e37
[14/16] scsi: mptsas: Use dma_alloc_coherent()
https://git.kernel.org/mkp/scsi/c/76a334d756c5
[15/16] scsi: mptctl: Use dma_alloc_coherent()
https://git.kernel.org/mkp/scsi/c/706dc3b91989
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-06 21:45 [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
` (2 preceding siblings ...)
2022-01-19 4:06 ` Martin K. Petersen
@ 2022-01-25 19:28 ` Moritz Fischer
2022-02-23 7:46 ` Christoph Hellwig
2022-02-25 16:20 ` Christoph Hellwig
5 siblings, 0 replies; 16+ messages in thread
From: Moritz Fischer @ 2022-01-25 19:28 UTC (permalink / raw)
To: Christophe JAILLET
Cc: arnd, hch, akpm, rth, ink, mattst88, mpe, benh, paulus, davem,
airlied, vkoul, hao.wu, trix, mdf, yilun.xu, awalls, mchehab,
sathya.prakash, sreekanth.reddy, suganath-prabu.subramani,
mporter, alex.bou9, bhelgaas, linux-alpha, linuxppc-dev,
sparclinux, dmaengine, linux-fpga, linux-media,
MPT-FusionLinux.pdl, linux-scsi, linux-pci, linux-kernel,
kernel-janitors
On Thu, Jan 06, 2022 at 10:45:13PM +0100, Christophe JAILLET wrote:
> This serie axes all the remaining usages of the deprecated "pci-dma-compat.h"
> API.
>
> All these patches have already been posted.
>
> They have been generated with a coccinelle script.
> The tricky parts are patches that use dma_alloc_coherent() because the correct
> GFP flag has to be used in place of the previous embedded GFP_ATOMIC.
>
> Patches 1-3 are already Reviewed. References to the corresponding mail is
> given below the ---
>
> Patch 1-2,4-10 are just generated from the coccinelle script. Only too long
> lines have been hand modified. dma_alloc_coherent() modification are NOT part
> of these patches.
>
> Patch 3 also includes some 'dma_set_mask_and_coherent()' instead of
> 'pci_set_dma_mask()/pci_set_consistent_dma_mask()'.
> I've left this additional modification because it was reviewed with it.
>
> Patch 10-15 are the tricky parts. Explanation of which GFP flag is the right one
> is given in each patch. It has been divided in several patches to ease review.
>
> Patch 15 is the only one I'm slighly unsure with. The old code was using a
> GFP_USER flag in the function. I'm not familiar with it.
> I *guess* that GFP_KERNEL is fine, but maybe it should also be GFP_USER or left
> as GFP_ATOMIC so that nothing is changed.
>
> Patch 16 is the last step that remove "pci-dma-compat.h" and its only usage.
>
>
> All patches, exept 1-2,6 that are architecture specific, have been compile tested.
>
>
> After all that, a few rst files, 1 or 2 strings in error messages and some
> error branching labels should still need some attention.
> This is some minor issues.
>
>
> Only the cover letter is sent to every one. Each patch is sent to the
> corresponding maintainer(s) + Andrew Morton, Christoph Hellwig and Arnd Bergmann.
>
>
> Best regards.
>
>
> Christophe JAILLET (16):
> alpha: Remove usage of the deprecated "pci-dma-compat.h" API
> floppy: Remove usage of the deprecated "pci-dma-compat.h" API
> fpga: dfl: pci: Remove usage of the deprecated "pci-dma-compat.h" API
> media: Remove usage of the deprecated "pci-dma-compat.h" API
> agp/intel: Remove usage of the deprecated "pci-dma-compat.h" API
> sparc: Remove usage of the deprecated "pci-dma-compat.h" API
> dmaengine: pch_dma: Remove usage of the deprecated "pci-dma-compat.h"
> API
> rapidio/tsi721: Remove usage of the deprecated "pci-dma-compat.h" API
> media: v4l2-pci-skeleton: Remove usage of the deprecated
> "pci-dma-compat.h" API
> scsi: message: fusion: Remove usage of the deprecated
> "pci-dma-compat.h" API
> scsi: mptbase: Use dma_alloc_coherent() in 'mpt_alloc_fw_memory()'
> scsi: mptbase: Use dma_alloc_coherent()
> scsi: mptsas: Use dma_alloc_coherent() in
> mptsas_exp_repmanufacture_info()
> scsi: mptsas: Use dma_alloc_coherent()
> scsi: mptctl: Use dma_alloc_coherent()
> PCI: Remove usage of the deprecated "pci-dma-compat.h" API
>
> arch/alpha/include/asm/floppy.h | 7 +-
> arch/alpha/kernel/pci_iommu.c | 12 +--
> arch/powerpc/include/asm/floppy.h | 8 +-
> arch/sparc/kernel/ioport.c | 2 +-
> drivers/char/agp/intel-gtt.c | 26 ++---
> drivers/dma/pch_dma.c | 2 +-
> drivers/fpga/dfl-pci.c | 14 +--
> drivers/media/pci/cx18/cx18-queue.h | 6 +-
> drivers/media/pci/ivtv/ivtv-queue.h | 25 +++--
> drivers/media/pci/ivtv/ivtv-udma.h | 8 +-
> drivers/message/fusion/mptbase.c | 149 ++++++++++++++++------------
> drivers/message/fusion/mptctl.c | 82 +++++++++------
> drivers/message/fusion/mptlan.c | 90 +++++++++--------
> drivers/message/fusion/mptsas.c | 94 +++++++++---------
> drivers/rapidio/devices/tsi721.c | 8 +-
> include/linux/pci-dma-compat.h | 129 ------------------------
> include/linux/pci.h | 3 -
> samples/v4l/v4l2-pci-skeleton.c | 2 +-
> 18 files changed, 289 insertions(+), 378 deletions(-)
> delete mode 100644 include/linux/pci-dma-compat.h
>
> --
> 2.32.0
>
Applied [03/16] to linux-fpga for-next.
Thanks,
Moritz
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 04/16] media: Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-07 7:10 ` Mauro Carvalho Chehab
@ 2022-02-18 13:11 ` Hans Verkuil
0 siblings, 0 replies; 16+ messages in thread
From: Hans Verkuil @ 2022-02-18 13:11 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Arnd Bergmann
Cc: Christophe JAILLET, Christoph Hellwig, Andrew Morton, awalls,
Linux Media Mailing List, Linux Kernel Mailing List,
kernel-janitors
On 07/01/2022 08:10, Mauro Carvalho Chehab wrote:
> Em Thu, 6 Jan 2022 19:51:47 -0500
> Arnd Bergmann <arnd@arndb.de> escreveu:
>
>> On Thu, Jan 6, 2022 at 4:50 PM Christophe JAILLET
>> <christophe.jaillet@wanadoo.fr> wrote:
>>>
>>> In [1], Christoph Hellwig has proposed to remove the wrappers in
>>> include/linux/pci-dma-compat.h.
>>>
>>> Some reasons why this API should be removed have been given by Julia
>>> Lawall in [2].
>>>
>>> A coccinelle script has been used to perform the needed transformation.
>>> It can be found in [3].
>>>
>>> [1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/
>>> [2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/
>>> [3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/
>>>
>>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>
>> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Mauro, could you pick this up directly? It has no dependencies on the rest of
>> the series.
>
> Sure, but I already closed the media merge window. If you prefer to
> apply it directly via your tree, that would be OK for me as well.
> If so, just let me know. On such case:
>
> Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>
I picked it up for inclusion in the media subsystem for 5.18.
Regards,
Hans
>
> Regards,
> Mauro
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-06 21:45 [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
` (3 preceding siblings ...)
2022-01-25 19:28 ` Moritz Fischer
@ 2022-02-23 7:46 ` Christoph Hellwig
2022-02-23 20:26 ` Christophe JAILLET
2022-02-25 16:20 ` Christoph Hellwig
5 siblings, 1 reply; 16+ messages in thread
From: Christoph Hellwig @ 2022-02-23 7:46 UTC (permalink / raw)
To: Christophe JAILLET
Cc: arnd, hch, akpm, rth, ink, mattst88, mpe, benh, paulus, davem,
airlied, vkoul, hao.wu, trix, mdf, yilun.xu, awalls, mchehab,
sathya.prakash, sreekanth.reddy, suganath-prabu.subramani,
mporter, alex.bou9, bhelgaas, linux-alpha, linuxppc-dev,
sparclinux, dmaengine, linux-fpga, linux-media,
MPT-FusionLinux.pdl, linux-scsi, linux-pci, linux-kernel,
kernel-janitors
Hi Christophe,
do you know what the state is in current linux-next?
I think we'll just want to queue up anything left at this point in the
dma-mapping or PCI tree and get it done.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-02-23 7:46 ` Christoph Hellwig
@ 2022-02-23 20:26 ` Christophe JAILLET
2022-02-23 20:42 ` Arnd Bergmann
2022-02-24 6:25 ` Christoph Hellwig
0 siblings, 2 replies; 16+ messages in thread
From: Christophe JAILLET @ 2022-02-23 20:26 UTC (permalink / raw)
To: Christoph Hellwig
Cc: arnd, akpm, ink, mattst88, mpe, benh, paulus, davem, airlied,
vkoul, hao.wu, trix, mdf, yilun.xu, awalls, mchehab,
sathya.prakash, sreekanth.reddy, suganath-prabu.subramani,
mporter, alex.bou9, bhelgaas, linux-alpha, linuxppc-dev,
sparclinux, dmaengine, linux-fpga, linux-media,
MPT-FusionLinux.pdl, linux-scsi, linux-pci
Le 23/02/2022 à 08:46, Christoph Hellwig a écrit :
> Hi Christophe,
>
> do you know what the state is in current linux-next?
>
> I think we'll just want to queue up anything left at this point in the
> dma-mapping or PCI tree and get it done.
>
Hi,
Patch 01, 04, 05, 06, 08, 09 have not reached -next yet.
They all still apply cleanly.
04 has been picked it up for inclusion in the media subsystem for 5.18.
The other ones all have 1 or more Reviewed-by:/Acked-by: tags.
Patch 16 must be resubmitted to add "#include <linux/dma-mapping.h>" in
order not to break builds.
All the other patches have landed in -next.
CJ
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-02-23 20:26 ` Christophe JAILLET
@ 2022-02-23 20:42 ` Arnd Bergmann
2022-02-24 6:25 ` Christoph Hellwig
1 sibling, 0 replies; 16+ messages in thread
From: Arnd Bergmann @ 2022-02-23 20:42 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Christoph Hellwig, Arnd Bergmann, Andrew Morton, Ivan Kokshaysky,
Matt Turner, Michael Ellerman, Benjamin Herrenschmidt,
Paul Mackerras, David Miller, David Airlie, Vinod Koul, hao.wu,
Tom Rix, Moritz Fischer, Xu Yilun, awalls, Mauro Carvalho Chehab,
Sathya Prakash, sreekanth.reddy, Suganath Prabu Subramani,
Matt Porter, Alex Bounine, Bjorn Helgaas, alpha, linuxppc-dev,
sparclinux, dmaengine, linux-fpga, Linux Media Mailing List,
MPT-FusionLinux.pdl, linux-scsi, linux-pci
On Wed, Feb 23, 2022 at 9:26 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> Le 23/02/2022 à 08:46, Christoph Hellwig a écrit :
> > Hi Christophe,
> >
> > do you know what the state is in current linux-next?
> >
> > I think we'll just want to queue up anything left at this point in the
> > dma-mapping or PCI tree and get it done.
> >
>
> Hi,
>
> Patch 01, 04, 05, 06, 08, 09 have not reached -next yet.
> They all still apply cleanly.
>
> 04 has been picked it up for inclusion in the media subsystem for 5.18.
> The other ones all have 1 or more Reviewed-by:/Acked-by: tags.
>
> Patch 16 must be resubmitted to add "#include <linux/dma-mapping.h>" in
> order not to break builds.
>
>
> All the other patches have landed in -next.
Ok, these all look trivial. I'd suggest you send the rebase version to
Andrew Morton then, so he can pick them all up into linux-mm, on top
of the linux-next contents.
Arnd
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-02-23 20:26 ` Christophe JAILLET
2022-02-23 20:42 ` Arnd Bergmann
@ 2022-02-24 6:25 ` Christoph Hellwig
2022-02-24 7:07 ` Arnd Bergmann
1 sibling, 1 reply; 16+ messages in thread
From: Christoph Hellwig @ 2022-02-24 6:25 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Christoph Hellwig, arnd, akpm, ink, mattst88, mpe, benh, paulus,
davem, airlied, vkoul, hao.wu, trix, mdf, yilun.xu, awalls,
mchehab, sathya.prakash, sreekanth.reddy,
suganath-prabu.subramani, mporter, alex.bou9, bhelgaas,
linux-alpha, linuxppc-dev, sparclinux, dmaengine, linux-fpga,
linux-media, MPT-FusionLinux.pdl, linux-scsi, linux-pci
On Wed, Feb 23, 2022 at 09:26:56PM +0100, Christophe JAILLET wrote:
> Patch 01, 04, 05, 06, 08, 09 have not reached -next yet.
> They all still apply cleanly.
>
> 04 has been picked it up for inclusion in the media subsystem for 5.18.
> The other ones all have 1 or more Reviewed-by:/Acked-by: tags.
>
> Patch 16 must be resubmitted to add "#include <linux/dma-mapping.h>" in
> order not to break builds.
So how about this: I'll pick up 1, 5,6,8 and 9 for the dma-mapping
tree. After -rc1 when presumably all other patches have reached
mainline your resubmit one with the added include and we finish this
off?
Thanks a lot for all your work already!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-02-24 6:25 ` Christoph Hellwig
@ 2022-02-24 7:07 ` Arnd Bergmann
2022-02-24 18:15 ` Christophe JAILLET
0 siblings, 1 reply; 16+ messages in thread
From: Arnd Bergmann @ 2022-02-24 7:07 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Christophe JAILLET, Arnd Bergmann, Andrew Morton, Ivan Kokshaysky,
Matt Turner, Michael Ellerman, Benjamin Herrenschmidt,
Paul Mackerras, David Miller, David Airlie, Vinod Koul, hao.wu,
Tom Rix, Moritz Fischer, Xu Yilun, awalls, Mauro Carvalho Chehab,
Sathya Prakash, sreekanth.reddy, Suganath Prabu Subramani,
Matt Porter, Alex Bounine, Bjorn Helgaas, alpha, linuxppc-dev,
sparclinux, dmaengine, linux-fpga, Linux Media Mailing List,
MPT-FusionLinux.pdl, linux-scsi, linux-pci
On Thu, Feb 24, 2022 at 7:25 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Feb 23, 2022 at 09:26:56PM +0100, Christophe JAILLET wrote:
> > Patch 01, 04, 05, 06, 08, 09 have not reached -next yet.
> > They all still apply cleanly.
> >
> > 04 has been picked it up for inclusion in the media subsystem for 5.18.
> > The other ones all have 1 or more Reviewed-by:/Acked-by: tags.
> >
> > Patch 16 must be resubmitted to add "#include <linux/dma-mapping.h>" in
> > order not to break builds.
>
> So how about this: I'll pick up 1, 5,6,8 and 9 for the dma-mapping
> tree. After -rc1 when presumably all other patches have reached
> mainline your resubmit one with the added include and we finish this
> off?
Sounds good to me as well.
Arnd
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-02-24 7:07 ` Arnd Bergmann
@ 2022-02-24 18:15 ` Christophe JAILLET
0 siblings, 0 replies; 16+ messages in thread
From: Christophe JAILLET @ 2022-02-24 18:15 UTC (permalink / raw)
To: Arnd Bergmann, Christoph Hellwig
Cc: Andrew Morton, Ivan Kokshaysky, Matt Turner, Michael Ellerman,
Benjamin Herrenschmidt, Paul Mackerras, David Miller,
David Airlie, Vinod Koul, hao.wu, Tom Rix, Moritz Fischer,
Xu Yilun, awalls, Mauro Carvalho Chehab, Sathya Prakash,
sreekanth.reddy, Suganath Prabu Subramani, Matt Porter,
Alex Bounine, Bjorn Helgaas, alpha, linuxppc-dev, sparclinux,
dmaengine, linux-fpga, Linux Media Mailing List,
MPT-FusionLinux.pdl, linux-scsi, linux-pci,
linux-kernel@vger.kernel.org, Kernel Janitors
Le 24/02/2022 à 08:07, Arnd Bergmann a écrit :
> On Thu, Feb 24, 2022 at 7:25 AM Christoph Hellwig <hch@infradead.org> wrote:
>> On Wed, Feb 23, 2022 at 09:26:56PM +0100, Christophe JAILLET wrote:
>>> Patch 01, 04, 05, 06, 08, 09 have not reached -next yet.
>>> They all still apply cleanly.
>>>
>>> 04 has been picked it up for inclusion in the media subsystem for 5.18.
>>> The other ones all have 1 or more Reviewed-by:/Acked-by: tags.
>>>
>>> Patch 16 must be resubmitted to add "#include <linux/dma-mapping.h>" in
>>> order not to break builds.
>> So how about this: I'll pick up 1, 5,6,8 and 9 for the dma-mapping
>> tree. After -rc1 when presumably all other patches have reached
>> mainline your resubmit one with the added include and we finish this
>> off?
> Sounds good to me as well.
>
> Arnd
This is fine for me.
When all patches have reached -next, I'll re-submit the fixed 16th patch.
Thanks for your assistance for ending this long story :)
CJ
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API
2022-01-06 21:45 [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
` (4 preceding siblings ...)
2022-02-23 7:46 ` Christoph Hellwig
@ 2022-02-25 16:20 ` Christoph Hellwig
5 siblings, 0 replies; 16+ messages in thread
From: Christoph Hellwig @ 2022-02-25 16:20 UTC (permalink / raw)
To: Christophe JAILLET
Cc: arnd, hch, akpm, rth, ink, mattst88, mpe, benh, paulus, davem,
airlied, vkoul, hao.wu, trix, mdf, yilun.xu, awalls, mchehab,
sathya.prakash, sreekanth.reddy, suganath-prabu.subramani,
mporter, alex.bou9, bhelgaas, linux-alpha, linuxppc-dev,
sparclinux, dmaengine, linux-fpga, linux-media,
MPT-FusionLinux.pdl, linux-scsi, linux-pci, linux-kernel,
kernel-janitors
I've applied patches 1,5,6,8 and 9 to the dma-mapping tree.
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2022-02-25 16:21 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-06 21:45 [PATCH 00/16] Remove usage of the deprecated "pci-dma-compat.h" API Christophe JAILLET
2022-01-06 21:50 ` [PATCH 04/16] media: " Christophe JAILLET
2022-01-07 0:51 ` Arnd Bergmann
2022-01-07 7:10 ` Mauro Carvalho Chehab
2022-02-18 13:11 ` Hans Verkuil
2022-01-10 8:44 ` Christoph Hellwig
2022-01-10 15:35 ` [PATCH 00/16] " Martin K. Petersen
2022-01-19 4:06 ` Martin K. Petersen
2022-01-25 19:28 ` Moritz Fischer
2022-02-23 7:46 ` Christoph Hellwig
2022-02-23 20:26 ` Christophe JAILLET
2022-02-23 20:42 ` Arnd Bergmann
2022-02-24 6:25 ` Christoph Hellwig
2022-02-24 7:07 ` Arnd Bergmann
2022-02-24 18:15 ` Christophe JAILLET
2022-02-25 16:20 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).