From: Christoph Hellwig <hch@lst.de>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc: Christoph Hellwig <hch@lst.de>,
ezequiel@vanguardiasur.com.ar, linux-media@vger.kernel.org,
laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl,
ribalda@chromium.org, tfiga@chromium.org, senozhatsky@google.com,
kernel@collabora.com
Subject: Re: [PATCH 3/3] media: stk1160: use dma_alloc_noncontiguous API
Date: Tue, 11 Jan 2022 09:52:30 +0100 [thread overview]
Message-ID: <20220111085230.GA22703@lst.de> (raw)
In-Reply-To: <65307131-533a-3de1-7877-ca3020743cbe@collabora.com>
On Tue, Jan 11, 2022 at 10:50:50AM +0200, Dafna Hirschfeld wrote:
> I'll send v2 with shorter lines. (the official limit is now 100 char which I still follow).
No. It is 80 lines with an exception to go over it if it sigificantly
improves readability.
> You mean you would call "invalidate_kernel_vmap_range" before "dma_sync_sgtable_for_cpu" ?
Yes.
next prev parent reply other threads:[~2022-01-11 8:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 6:55 [PATCH 0/3] media: stk1160: allocate urb buffs with the DMA noncontiguous API Dafna Hirschfeld
2022-01-11 6:55 ` [PATCH 1/3] media: stk1160: fix number of buffers in case not all buffers are created Dafna Hirschfeld
2022-01-11 12:21 ` Ezequiel Garcia
2022-01-11 6:55 ` [PATCH 2/3] media: stk1160: move transfer_buffer and urb to same struct 'stk1160_urb' Dafna Hirschfeld
2022-01-11 8:10 ` Christoph Hellwig
2022-01-11 12:29 ` Ezequiel Garcia
2022-01-11 6:55 ` [PATCH 3/3] media: stk1160: use dma_alloc_noncontiguous API Dafna Hirschfeld
2022-01-11 8:13 ` Christoph Hellwig
2022-01-11 8:50 ` Dafna Hirschfeld
2022-01-11 8:52 ` Christoph Hellwig [this message]
2022-01-11 8:55 ` Dafna Hirschfeld
2022-01-11 8:59 ` Christoph Hellwig
2022-01-12 9:25 ` Sergey Senozhatsky
2022-01-11 12:38 ` Ezequiel Garcia
2022-01-24 14:43 ` Dafna Hirschfeld
2022-01-24 16:02 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111085230.GA22703@lst.de \
--to=hch@lst.de \
--cc=dafna.hirschfeld@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=senozhatsky@google.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).