From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] media: usb: pwc-uncompress: Use struct_size() helper in pwc_decompress()
Date: Thu, 20 Jan 2022 15:22:38 -0800 [thread overview]
Message-ID: <202201201522.7BEEF4E@keescook> (raw)
In-Reply-To: <20220120212434.GA30630@embeddedor>
On Thu, Jan 20, 2022 at 03:24:34PM -0600, Gustavo A. R. Silva wrote:
> Make use of the struct_size() helper instead of an open-coded version,
> in order to avoid any potential type mistakes or integer overflows that,
> in the worst scenario, could lead to heap overflows.
>
> Also, address the following sparse warnings:
> drivers/media/usb/pwc/pwc-uncompress.c:44:44: warning: using sizeof on a flexible structure
>
> Link: https://github.com/KSPP/linux/issues/174
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Yup, happy to see these getting changed.
Reviewed-by: Kees Cook <keescook@chromium.org>
> ---
> drivers/media/usb/pwc/pwc-uncompress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/pwc/pwc-uncompress.c b/drivers/media/usb/pwc/pwc-uncompress.c
> index 68bc3829c6b3..faf44cdeb268 100644
> --- a/drivers/media/usb/pwc/pwc-uncompress.c
> +++ b/drivers/media/usb/pwc/pwc-uncompress.c
> @@ -41,7 +41,7 @@ int pwc_decompress(struct pwc_device *pdev, struct pwc_frame_buf *fbuf)
> memcpy(raw_frame->cmd, pdev->cmd_buf, 4);
> memcpy(raw_frame+1, yuv, pdev->frame_size);
> vb2_set_plane_payload(&fbuf->vb.vb2_buf, 0,
> - pdev->frame_size + sizeof(struct pwc_raw_frame));
> + struct_size(raw_frame, rawframe, pdev->frame_size));
> return 0;
> }
>
> --
> 2.27.0
>
--
Kees Cook
prev parent reply other threads:[~2022-01-20 23:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 21:24 [PATCH][next] media: usb: pwc-uncompress: Use struct_size() helper in pwc_decompress() Gustavo A. R. Silva
2022-01-20 23:22 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201201522.7BEEF4E@keescook \
--to=keescook@chromium.org \
--cc=gustavoars@kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).