From: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
To: ezequiel@vanguardiasur.com.ar
Cc: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
kernel@collabora.com, linux-media@vger.kernel.org,
laurent.pinchart@ideasonboard.com, hverkuil@xs4all.nl,
ribalda@chromium.org, tfiga@chromium.org, senozhatsky@google.com,
hch@lst.de, dafna3@gmail.com
Subject: [PATCH v2 0/4] stk1160: allocate urb buffs with the DMA noncontiguous API
Date: Tue, 25 Jan 2022 10:02:09 +0200 [thread overview]
Message-ID: <20220125080213.30090-1-dafna.hirschfeld@collabora.com> (raw)
This set replaces urb buffers allocation to use the DMA
noncontiguous API. Similarly to a commit sent to uvc: [1]
This improves performance on ARM while not damaging performance
on other platforms. The cpu performance on ARM
improves because the new API does not cause the cache disable on ARM
while the coherent API do.
Measurements are shown in patch 4/4
[1] https://lkml.org/lkml/2021/3/12/1506
Patches Summary:
* patches 1+2 are bug fixes.
* patch 3 changes the way data is stored. This is a preparation
to patch 4.
* patch 4 is the change of API to use the noncontiguougs.
Changes since v1:
1. reduce line length to be not too longer than 80 char
2. reformulate commit log of patch 4/4 and add measurements results
3. in patch 4, invalidate the vmap range before the direct mapping range.
4. test regressions for patches 1-3 (not including patch 4) and improve vars names
5. patch 2 is a new bug fix I found
6. patch 1 is extended to fix two cases of not allocating all intended urb buffers.
Dafna Hirschfeld (4):
media: stk1160: fix number of buffers in case not all buffers are
created
media: stk1160: If start stream fails, return buffers with
VB2_BUF_STATE_QUEUED
media: stk1160: move transfer_buffer and urb to same struct
'stk1160_urb'
media: stk1160: use dma_alloc_noncontiguous API
drivers/media/usb/stk1160/stk1160-core.c | 2 +-
drivers/media/usb/stk1160/stk1160-v4l.c | 16 ++-
drivers/media/usb/stk1160/stk1160-video.c | 142 ++++++++++++----------
drivers/media/usb/stk1160/stk1160.h | 23 +++-
4 files changed, 104 insertions(+), 79 deletions(-)
--
2.17.1
next reply other threads:[~2022-01-25 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 8:02 Dafna Hirschfeld [this message]
2022-01-25 8:02 ` [PATCH v2 1/4] media: stk1160: fix number of buffers in case not all buffers are created Dafna Hirschfeld
2022-02-06 11:39 ` Ezequiel Garcia
2022-01-25 8:02 ` [PATCH v2 2/4] media: stk1160: If start stream fails, return buffers with VB2_BUF_STATE_QUEUED Dafna Hirschfeld
2022-02-06 11:40 ` Ezequiel Garcia
2022-01-25 8:02 ` [PATCH v2 3/4] media: stk1160: move transfer_buffer and urb to same struct 'stk1160_urb' Dafna Hirschfeld
2022-02-07 15:08 ` Ezequiel Garcia
2022-01-25 8:02 ` [PATCH v2 4/4] media: stk1160: use dma_alloc_noncontiguous API Dafna Hirschfeld
2022-02-07 15:13 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125080213.30090-1-dafna.hirschfeld@collabora.com \
--to=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hch@lst.de \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=ribalda@chromium.org \
--cc=senozhatsky@google.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox