Re: [PATCH v2 19/66] media: sun6i-csi: Grab bus clock instead of passing it to regmap

Maxime Ripard
2022-02-09T10:38:33Z

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

Hi,

On Sat, Feb 05, 2022 at 07:53:42PM +0100, Paul Kocialkowski wrote:
> Since the bus clock alone is not enough to get access to the registers,
> don't pass it to regmap and manage it instead just like the other
> clocks.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

I'm not really sure about this one.

Sure, there's more resources involved than the clock to get access to
the registers (like reset), but you can't have a functional device
without the reset line deasserted.

You can however have a functional device without the bus clock enabled,
so it just seems much better to let regmap manage it.

Unless there's a drawback to it of course, but it should be in your
commit log if so.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]