Linux Media Controller development
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: False 'uninitialized symbol' messages in latest smatch
Date: Fri, 11 Mar 2022 23:30:55 +0300	[thread overview]
Message-ID: <20220311203055.GM3315@kadam> (raw)
In-Reply-To: <857e12d1-a803-bb97-813d-02e4df0e237e@xs4all.nl>

On Fri, Mar 11, 2022 at 02:22:53PM +0100, Hans Verkuil wrote:
> Hi Dan,
> 
> With the latest smatch I get a lot of 'uninitialized symbol' errors that
> all appear to be related to the use of the min/max/abs macros.
> 
> It's clearly seen here:
> 
> include/media/v4l2-rect.h:127 v4l2_rect_intersect() error: uninitialized symbol 'bottom'.
> include/media/v4l2-rect.h:128 v4l2_rect_intersect() error: uninitialized symbol 'right'.
> 
> drivers/media/usb/uvc/uvc_v4l2.c:445 uvc_v4l2_set_streamparm() error: uninitialized symbol 'maxd'.
> drivers/media/usb/uvc/uvc_v4l2.c:457 uvc_v4l2_set_streamparm() error: uninitialized symbol 'd'.
> 
> The logs of my daily media build from last night are here:
> 
> https://hverkuil.home.xs4all.nl/logs/Friday.log 
> 
> Too many of these appear to be incorrect errors.

Sorry, about that!  I've pushed a fix for it now.

regards,
dan carpenter

      reply	other threads:[~2022-03-11 20:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 13:22 False 'uninitialized symbol' messages in latest smatch Hans Verkuil
2022-03-11 20:30 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220311203055.GM3315@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox