From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kate Hsuan <hpa@redhat.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, hdegoede@redhat.com
Subject: Re: [PATCH v3] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used
Date: Fri, 8 Apr 2022 13:52:42 +0300 [thread overview]
Message-ID: <20220408105242.GT3293@kadam> (raw)
In-Reply-To: <20220408104222.13893-1-hpa@redhat.com>
On Fri, Apr 08, 2022 at 06:42:22PM +0800, Kate Hsuan wrote:
> An not calibrated x_start setting would result in an incorrect AWB grid
> configuration on a sensor when only the rightmost stripe is used.
>
> If the AWB grid coordinate is set to the rightmost stripe, for example,
> x_start is greater than 640, the AWB grid will be at the rightmost edge of
> the sensor. The AWB statistic will be fetched from the wrong place of the
> sensor and results in an incorrect AWB estimation result. Therefore,
> stripe offset should subtract from x_start to have a correct grid
> configuration for the rightmost stripe.
>
Thank you!
regards,
dan carpenter
prev parent reply other threads:[~2022-04-08 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 10:42 [PATCH v3] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used Kate Hsuan
2022-04-08 10:52 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220408105242.GT3293@kadam \
--to=dan.carpenter@oracle.com \
--cc=bingbu.cao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hpa@redhat.com \
--cc=jeanmichel.hautbois@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox