Re: [PATCH v3 5/5] drivers: media: platform: Add NPCM Video Capture/Encode Engine driver

kernel test robot
2022-05-20T21:54:24Z

Hi Marvin,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linux/master linus/master v5.18-rc7]
[cannot apply to media-tree/master next-20220520]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Marvin-Lin/Support-Nuvoton-NPCM-Video-Capture-Encode-Engine/20220520-104901
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220521/202205210506.qGHSKHPp-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/56e41b3b4b1a54f2096e810eda12259da495c686
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Marvin-Lin/Support-Nuvoton-NPCM-Video-Capture-Encode-Engine/20220520-104901
git checkout 56e41b3b4b1a54f2096e810eda12259da495c686
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/media/platform/nuvoton/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/media/platform/nuvoton/npcm-video.c:2050:1: error: expected ',' or ';' before 'static'
2050 | static struct platform_driver nuvoton_video_driver = {
| ^~~~~~
In file included from drivers/media/platform/nuvoton/npcm-video.c:24:
drivers/media/platform/nuvoton/npcm-video.c: In function 'nuvoton_video_driver_init':
>> drivers/media/platform/nuvoton/npcm-video.c:2059:24: error: 'nuvoton_video_driver' undeclared (first use in this function); did you mean 'nuvoton_video_probe'?
2059 | module_platform_driver(nuvoton_video_driver);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/platform_device.h:222:36: note: in definition of macro 'platform_driver_register'
222 | __platform_driver_register(drv, THIS_MODULE)
| ^~~
include/linux/platform_device.h:252:9: note: in expansion of macro 'module_driver'
252 | module_driver(__platform_driver, platform_driver_register, \
| ^~~~~~~~~~~~~
drivers/media/platform/nuvoton/npcm-video.c:2059:1: note: in expansion of macro 'module_platform_driver'
2059 | module_platform_driver(nuvoton_video_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/nuvoton/npcm-video.c:2059:24: note: each undeclared identifier is reported only once for each function it appears in
2059 | module_platform_driver(nuvoton_video_driver);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/platform_device.h:222:36: note: in definition of macro 'platform_driver_register'
222 | __platform_driver_register(drv, THIS_MODULE)
| ^~~
include/linux/platform_device.h:252:9: note: in expansion of macro 'module_driver'
252 | module_driver(__platform_driver, platform_driver_register, \
| ^~~~~~~~~~~~~
drivers/media/platform/nuvoton/npcm-video.c:2059:1: note: in expansion of macro 'module_platform_driver'
2059 | module_platform_driver(nuvoton_video_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/device.h:32,
from drivers/media/platform/nuvoton/npcm-video.c:14:
drivers/media/platform/nuvoton/npcm-video.c: In function 'nuvoton_video_driver_exit':
>> drivers/media/platform/nuvoton/npcm-video.c:2059:24: error: 'nuvoton_video_driver' undeclared (first use in this function); did you mean 'nuvoton_video_probe'?
2059 | module_platform_driver(nuvoton_video_driver);
| ^~~~~~~~~~~~~~~~~~~~
include/linux/device/driver.h:267:24: note: in definition of macro 'module_driver'
267 | __unregister(&(__driver) , ##__VA_ARGS__); \
| ^~~~~~~~
drivers/media/platform/nuvoton/npcm-video.c:2059:1: note: in expansion of macro 'module_platform_driver'
2059 | module_platform_driver(nuvoton_video_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/media/platform/nuvoton/npcm-video.c: In function 'nuvoton_video_driver_init':
include/linux/device/driver.h:263:1: error: control reaches end of non-void function [-Werror=return-type]
263 | } \
| ^
include/linux/platform_device.h:252:9: note: in expansion of macro 'module_driver'
252 | module_driver(__platform_driver, platform_driver_register, \
| ^~~~~~~~~~~~~
drivers/media/platform/nuvoton/npcm-video.c:2059:1: note: in expansion of macro 'module_platform_driver'
2059 | module_platform_driver(nuvoton_video_driver);
| ^~~~~~~~~~~~~~~~~~~~~~
At top level:
drivers/media/platform/nuvoton/npcm-video.c:2020:12: warning: 'nuvoton_video_remove' defined but not used [-Wunused-function]
2020 | static int nuvoton_video_remove(struct platform_device *pdev)
| ^~~~~~~~~~~~~~~~~~~~
drivers/media/platform/nuvoton/npcm-video.c:1944:12: warning: 'nuvoton_video_probe' defined but not used [-Wunused-function]
1944 | static int nuvoton_video_probe(struct platform_device *pdev)
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +2050 drivers/media/platform/nuvoton/npcm-video.c

2049
> 2050 static struct platform_driver nuvoton_video_driver = {
2051 .driver = {
2052 .name = DEVICE_NAME,
2053 .of_match_table = nuvoton_video_match,
2054 },
2055 .probe = nuvoton_video_probe,
2056 .remove = nuvoton_video_remove,
2057 };
2058
> 2059 module_platform_driver(nuvoton_video_driver);
2060

--
0-DAY CI Kernel Test Service