From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A792C433EF for ; Mon, 30 May 2022 11:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235614AbiE3Lh5 (ORCPT ); Mon, 30 May 2022 07:37:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235626AbiE3Lh4 (ORCPT ); Mon, 30 May 2022 07:37:56 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30A184EF76 for ; Mon, 30 May 2022 04:37:55 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id l19so2406286ejr.8 for ; Mon, 30 May 2022 04:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/LkbtPQcvwsRsFCT5B2kafAu6Wm//Jx4TksDG+egz0c=; b=qj5/Flbj+znEbYrCKN88/BLH1DQQSNRbO1JdpNo36o4slyOTzw8AGeygowAM4/6woR l81CdycuLucbenbuxFf4zJAIQ00vD2NIvMG45LP+4H3+jumcWpH6EVpzhsP+dIY/DCk2 cic8Du6ej5Y1v+OKZuTbzmic5vp0jr8aGdRVY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/LkbtPQcvwsRsFCT5B2kafAu6Wm//Jx4TksDG+egz0c=; b=rcOExyYy0CeVocw+0brcES9hl02LX3BTiONItTVjIz93xProxaOp1kffi0NEz3uBjN 8iFMXbHTocGaM0/ElBxtQi1OyI+bdwWRUr7L0IC6qWt6EOTprAFptmskZgkiKMMAL82k 1hVg5JsoTBUrKAqHQzEkW7TNzwx2WzAe44/6REDTI7TMUj3g9m/IOiIdOgaoFPKH7Geo t6ivRbAJV+1RwJyQ5XeDpwmZ1mXYAQSCy90y0sICuK+uZopLVCjA+vgI9/ff1HoyRsFf vUaRydjdQaWhCz3ng5iH+WKgeZHokP4o1zQu/NfiO9XhP8jpM8XJT8zwoa2LqGKnmbI8 +mag== X-Gm-Message-State: AOAM533yIYI55el5Z5GOHNSCctePY3YYrdoPY3ywkrFgeOFzhHT1qsDO jbTr6ZMfMuVg0KZRy2DRvoc06Q== X-Google-Smtp-Source: ABdhPJz/AQ/g9cFWSF/kO0IUjFAcw7PU+/bypjmMqBnz8vJn84FyVYW3yTumja8Cn3A5+anbddCwXA== X-Received: by 2002:a17:907:3f89:b0:6fe:e7a7:c038 with SMTP id hr9-20020a1709073f8900b006fee7a7c038mr32987693ejc.730.1653910673717; Mon, 30 May 2022 04:37:53 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (net-2-39-143-183.cust.vodafonedsl.it. [2.39.143.183]) by smtp.gmail.com with ESMTPSA id z1-20020a1709060ac100b006f3ef214de1sm3900692ejf.71.2022.05.30.04.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 04:37:53 -0700 (PDT) Date: Mon, 30 May 2022 13:37:50 +0200 From: Tommaso Merciai To: Haowen Bai Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: atomisp-mt9m114: Fix pointer dereferenced before checking Message-ID: <20220530113750.GD99280@tom-ThinkPad-T14s-Gen-2i> References: <1653897481-25681-1-git-send-email-baihaowen@meizu.com> <20220530112232.GB99280@tom-ThinkPad-T14s-Gen-2i> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220530112232.GB99280@tom-ThinkPad-T14s-Gen-2i> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, May 30, 2022 at 01:22:32PM +0200, Tommaso Merciai wrote: > On Mon, May 30, 2022 at 03:58:01PM +0800, Haowen Bai wrote: > > The info->data is dereferencing before null checking, so move > > it after checking. > > > > Signed-off-by: Haowen Bai > > --- > > drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c > > index 00d6842c07d6..3c81ab73cdae 100644 > > --- a/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c > > +++ b/drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c > > @@ -616,13 +616,15 @@ static int mt9m114_get_intg_factor(struct i2c_client *client, > > struct camera_mipi_info *info, > > const struct mt9m114_res_struct *res) > > { > > - struct atomisp_sensor_mode_data *buf = &info->data; > > + struct atomisp_sensor_mode_data *buf; > > u32 reg_val; > > int ret; > > > > if (!info) > > return -EINVAL; > > > > + buf = &info->data; > > + > > ret = mt9m114_read_reg(client, MISENSOR_32BIT, > > REG_PIXEL_CLK, ®_val); > > if (ret) > > -- > > 2.7.4 > > > > Hi Haowen, > Looks good to me, thanks. > > Reviewed-by: Tommaso Merciai Hi, My bad, Dan is right. Nothing to fix here. Sorry for previous review. Regards, Tommaso > -- > Tommaso Merciai > Embedded Linux Engineer > tommaso.merciai@amarulasolutions.com > __________________________________ > > Amarula Solutions SRL > Via Le Canevare 30, 31100 Treviso, Veneto, IT > T. +39 042 243 5310 > info@amarulasolutions.com > www.amarulasolutions.com -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com