From: Dan Carpenter <dan.carpenter@oracle.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ricardo Ribalda <ribalda@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: fix a crash in uvc_ctrl_init_ctrl()
Date: Wed, 20 Jul 2022 12:20:48 +0300 [thread overview]
Message-ID: <20220720092048.GI2338@kadam> (raw)
In-Reply-To: <YtcxkInnG3DUGbOr@pendragon.ideasonboard.com>
On Wed, Jul 20, 2022 at 01:34:56AM +0300, Laurent Pinchart wrote:
> Hi Dan,
>
> Thank you for the patch.
>
> On Tue, Jul 19, 2022 at 04:45:29PM +0300, Dan Carpenter wrote:
> > There is a path where "mapping" is NULL when we try to process the
> > common mappings so it will crash.
> >
> > Fixes: 86f7ef773156 ("media: uvcvideo: Add support for per-device control mapping overrides")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I've submitted [1] to fix this issue, and [2] to replace all the
> error-prone loops in this function.
>
> [1] https://lore.kernel.org/linux-media/20220718121219.16079-1-laurent.pinchart@ideasonboard.com/
> [2] https://lore.kernel.org/linux-media/20220718222757.8203-1-laurent.pinchart@ideasonboard.com/T/#u
>
Ah, perfect. Thank you!
regards,
dan carpenter
> > ---
> > This bug was previously reported by the kbuild bot and fixed in later
> > versions of the patchset. The git log doesn't have a link to
> > lore.kernel.org but I suspect an earlier version got merged?
prev parent reply other threads:[~2022-07-20 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 13:45 [PATCH] media: uvcvideo: fix a crash in uvc_ctrl_init_ctrl() Dan Carpenter
2022-07-19 22:34 ` Laurent Pinchart
2022-07-20 9:20 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720092048.GI2338@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox