Re: [PATCH 6/6] staging: media: imx: Make imx_media_of_add_csi() static

paul.elder
2022-09-08T04:21:06Z

On Wed, Sep 07, 2022 at 11:04:24PM +0300, Laurent Pinchart wrote:
> The imx_media_of_add_csi() function is only called in its compilation
> unit. Make it static and don't export it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
> drivers/staging/media/imx/imx-media-of.c | 5 ++---
> drivers/staging/media/imx/imx-media.h | 2 --
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-of.c b/drivers/staging/media/imx/imx-media-of.c
> index 59f1eb7b62bc..92a99010c150 100644
> --- a/drivers/staging/media/imx/imx-media-of.c
> +++ b/drivers/staging/media/imx/imx-media-of.c
> @@ -16,8 +16,8 @@
> #include <video/imx-ipu-v3.h>
> #include "imx-media.h"
>
> -int imx_media_of_add_csi(struct imx_media_dev *imxmd,
> - struct device_node *csi_np)
> +static int imx_media_of_add_csi(struct imx_media_dev *imxmd,
> + struct device_node *csi_np)
> {
> struct v4l2_async_subdev *asd;
> int ret = 0;
> @@ -41,7 +41,6 @@ int imx_media_of_add_csi(struct imx_media_dev *imxmd,
>
> return ret;
> }
> -EXPORT_SYMBOL_GPL(imx_media_of_add_csi);
>
> int imx_media_add_of_subdevs(struct imx_media_dev *imxmd,
> struct device_node *np)
> diff --git a/drivers/staging/media/imx/imx-media.h b/drivers/staging/media/imx/imx-media.h
> index 5a1436dbb12d..c12ecaf378fe 100644
> --- a/drivers/staging/media/imx/imx-media.h
> +++ b/drivers/staging/media/imx/imx-media.h
> @@ -252,8 +252,6 @@ void imx_media_unregister_ipu_internal_subdevs(struct imx_media_dev *imxmd);
> /* imx-media-of.c */
> int imx_media_add_of_subdevs(struct imx_media_dev *dev,
> struct device_node *np);
> -int imx_media_of_add_csi(struct imx_media_dev *imxmd,
> - struct device_node *csi_np);
>
> /* imx-media-vdic.c */
> struct v4l2_subdev *imx_media_vdic_register(struct v4l2_device *v4l2_dev,