Re: [PATCH 4/6] staging: media: imx: Drop IMX_MEDIA_GRP_ID_CSI

paul.elder
2022-09-08T04:11:03Z

On Wed, Sep 07, 2022 at 11:04:22PM +0300, Laurent Pinchart wrote:
> The IMX_MEDIA_GRP_ID_CSI group ID isn't used anymore. Drop it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder@ideasonboard.com>

> ---
> drivers/staging/media/imx/imx-media-dev-common.c | 1 -
> drivers/staging/media/imx/imx-media.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-dev-common.c b/drivers/staging/media/imx/imx-media-dev-common.c
> index 8f7ced3a9cca..991820a8500f 100644
> --- a/drivers/staging/media/imx/imx-media-dev-common.c
> +++ b/drivers/staging/media/imx/imx-media-dev-common.c
> @@ -39,7 +39,6 @@ static void imx_media_create_csi2_links(struct imx_media_dev *imxmd)
> list_for_each_entry(sd, &imxmd->v4l2_dev.subdevs, list) {
> /* skip if not a CSI or a CSI mux */
> if (!(sd->grp_id & IMX_MEDIA_GRP_ID_IPU_CSI) &&
> - !(sd->grp_id & IMX_MEDIA_GRP_ID_CSI) &&
> !(sd->grp_id & IMX_MEDIA_GRP_ID_CSI_MUX))
> continue;
>
> diff --git a/drivers/staging/media/imx/imx-media.h b/drivers/staging/media/imx/imx-media.h
> index f263fc3adbb9..5e794f291da6 100644
> --- a/drivers/staging/media/imx/imx-media.h
> +++ b/drivers/staging/media/imx/imx-media.h
> @@ -299,7 +299,6 @@ void imx_media_csc_scaler_device_unregister(struct imx_media_video_dev *vdev);
>
> /* subdev group ids */
> #define IMX_MEDIA_GRP_ID_CSI2 BIT(8)
> -#define IMX_MEDIA_GRP_ID_CSI BIT(9)
> #define IMX_MEDIA_GRP_ID_IPU_CSI_BIT 10
> #define IMX_MEDIA_GRP_ID_IPU_CSI (0x3 << IMX_MEDIA_GRP_ID_IPU_CSI_BIT)
> #define IMX_MEDIA_GRP_ID_IPU_CSI0 BIT(IMX_MEDIA_GRP_ID_IPU_CSI_BIT)