Re: [PATCH 0/6] media: imx: imx7-media-csi: Destage driver

Alexander Stein
2022-09-13T09:48:18Z

Hello Laurent,

thanks for the patch and putting in some progress.

Am Mittwoch, 7. September 2022, 22:04:18 CEST schrieb Laurent Pinchart:
> Hello,
>
> This patch series is the last step of the imx7-media-csi driver
> destaging journey. Patch 1/6 starts by decoupling the imx7-media-csi and
> imx8mq-mipi-csi2 drivers in Kconfig, and patch 2/6 performs the
> destaging. Patches 3/6 to 6/6 then handle the low-hanging fruits of the
> staging imx cleanup by dropping features that were only used by the
> imx7-media-csi driver.
>
> The patches apply on top of [1].
>
> https://lore.kernel.org/linux-media/20220907191547.19255-1-laurent.pinchart@
> ideasonboard.com
>
> Laurent Pinchart (6):
> media: imx: Decouple imx8mq-mipi-csi2 from imx7-media-csi
> media: imx: Unstage the imx7-media-csi driver
> staging: media: imx: Drop imx_media_subdev_bound()
> staging: media: imx: Drop IMX_MEDIA_GRP_ID_CSI
> staging: media: imx: Drop unused helper functions
> staging: media: imx: Make imx_media_of_add_csi() static
>
> MAINTAINERS | 2 +-
> drivers/media/platform/nxp/Kconfig | 13 ++++
> drivers/media/platform/nxp/Makefile | 1 +
> .../platform/nxp}/imx7-media-csi.c | 24 +++++++
> drivers/staging/media/imx/Kconfig | 17 +++--
> drivers/staging/media/imx/Makefile | 3 +-
> drivers/staging/media/imx/TODO | 29 --------
> .../staging/media/imx/imx-media-dev-common.c | 14 ----
> drivers/staging/media/imx/imx-media-of.c | 5 +-
> drivers/staging/media/imx/imx-media-utils.c | 68 -------------------
> drivers/staging/media/imx/imx-media.h | 13 ----
> 11 files changed, 52 insertions(+), 137 deletions(-)
> rename drivers/{staging/media/imx => media/platform/nxp}/imx7-media-csi.c
> (97%)

I could test this on TQMa8MQ (imx8mq) based platform with an OV9281 gray
camera. I had a lot of frame drops when showing on wayland, but a
fpsdisplaysink combined with testsink showed ~36 FPS. This is the same as
before this series.

So I guess, you can add
Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com>