Re: [V14,08/15] dt-bindings: mediatek: Add mediatek,mt8195-jpgdec compatible

Krzysztof Kozlowski
2022-09-26T06:36:53Z

On 26/09/2022 03:56, kyrie.wu wrote:
> On Fri, 2022-09-23 at 13:28 +0200, Krzysztof Kozlowski wrote:
>> On 15/09/2022 08:43, Irui Wang wrote:
>>> From: kyrie wu <kyrie.wu@mediatek.com>
>>>
>>> Add mediatek,mt8195-jpgdec compatible to binding document.
>>
>> Use scripts/get_maintainers.pl to CC all maintainers and relevant
>> mailing lists.
>>
>>>
>>> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
>>> Signed-off-by: irui wang <irui.wang@mediatek.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../media/mediatek,mt8195-jpegdec.yaml | 169
>>> ++++++++++++++++++
>>> 1 file changed, 169 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> b/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> new file mode 100644
>>> index 000000000000..9135cf889d1e
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> @@ -0,0 +1,169 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id:
>>> https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek,mt8195-jpegdec.yaml*__;Iw!!CTRNKA9wMg0ARbw!yu00-_vltBz3bkDyzkeH2PENGyfi_megjPx815JiqrNVa28ZU7kcFYidMEos_id7$
>>>
>>> +$schema:
>>> https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!yu00-_vltBz3bkDyzkeH2PENGyfi_megjPx815JiqrNVa28ZU7kcFYidMAikt6uh$
>>>
>>> +
>>> +title: MediaTek JPEG Encoder Device Tree Bindings
>>> +
>>> +maintainers:
>>> + - kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>
>>> +
>>> +description:
>>> + MediaTek JPEG Decoder is the JPEG decode hardware present in
>>> MediaTek SoCs
>>> +
>>> +properties:
>>> + compatible:
>>> + items:
>>
>> You do not have more than one item. Skip items.
>
> Hello Krzysztof,
>
> The device node has the compatible of "mediatek,mt8195-jpgdec",
> if skip this item, it may case dt-binding checking error.

No, this won't happen if you use correct syntax.

> For another, we may extend this items in the future.

Not really, that would be change of ABI. If you have already list of
devices, include them now.

Best regards,
Krzysztof