Re: [V14,08/15] dt-bindings: mediatek: Add mediatek,mt8195-jpgdec compatible

Krzysztof Kozlowski
2022-09-23T11:29:09Z

On 15/09/2022 08:43, Irui Wang wrote:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> Add mediatek,mt8195-jpgdec compatible to binding document.

Use scripts/get_maintainers.pl to CC all maintainers and relevant
mailing lists.

>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> Signed-off-by: irui wang <irui.wang@mediatek.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../media/mediatek,mt8195-jpegdec.yaml | 169 ++++++++++++++++++
> 1 file changed, 169 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> new file mode 100644
> index 000000000000..9135cf889d1e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> @@ -0,0 +1,169 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mt8195-jpegdec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek JPEG Encoder Device Tree Bindings
> +
> +maintainers:
> + - kyrie wu <kyrie.wu@mediatek.corp-partner.google.com>
> +
> +description:
> + MediaTek JPEG Decoder is the JPEG decode hardware present in MediaTek SoCs
> +
> +properties:
> + compatible:
> + items:

You do not have more than one item. Skip items.

> + - const: mediatek,mt8195-jpgdec
> +
> + power-domains:
> + maxItems: 1
> +
> + iommus:
> + maxItems: 6
> + description:
> + Points to the respective IOMMU block with master port as argument, see
> + Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.
> + Ports are according to the HW.
> +
> + dma-ranges:
> + maxItems: 1
> + description: |
> + Describes the physical address space of IOMMU maps to memory.
> +
> + "#address-cells":
> + const: 2
> +
> + "#size-cells":
> + const: 2
> +
> + ranges: true
> +
> +# Required child node:
> +patternProperties:
> + "^jpgdec@[0-9a-f]+$":
> + type: object
> + description:
> + The jpeg decoder hardware device node which should be added as subnodes to
> + the main jpeg node.
> +
> + properties:
> + compatible:
> + const: mediatek,mt8195-jpgdec-hw
> +
> + reg:
> + maxItems: 1
> +
> + iommus:
> + minItems: 1
> + maxItems: 32
> + description:
> + List of the hardware port in respective IOMMU block for current Socs.
> + Refer to bindings/iommu/mediatek,iommu.yaml.
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: jpgdec
> +
> + power-domains:
> + maxItems: 1
> +
> + required:
> + - compatible
> + - reg
> + - iommus
> + - interrupts
> + - clocks
> + - clock-names
> + - power-domains
> +
> + additionalProperties: false
> +
> +required:
> + - compatible
> + - power-domains
> + - iommus
> + - dma-ranges
> + - ranges
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/memory/mt8195-memory-port.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/mt8195-clk.h>
> + #include <dt-bindings/power/mt8195-power.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + jpgdec_master {

No underscores in node names.

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> + compatible = "mediatek,mt8195-jpgdec";
> + power-domains = <&spm MT8195_POWER_DOMAIN_VDEC1>;
> + iommus = <&iommu_vpp M4U_PORT_L19_JPGDEC_WDMA0>,
> + <&iommu_vpp M4U_PORT_L19_JPGDEC_BSDMA0>,
> + <&iommu_vpp M4U_PORT_L19_JPGDEC_WDMA1>,
> + <&iommu_vpp M4U_PORT_L19_JPGDEC_BSDMA1>,
> + <&iommu_vpp M4U_PORT_L19_JPGDEC_BUFF_OFFSET1>,
> + <&iommu_vpp M4U_PORT_L19_JPGDEC_BUFF_OFFSET0>;
> + dma-ranges = <0x1 0x0 0x0 0x40000000 0x0 0xfff00000>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;

Mess up indentation.

Best regards,
Krzysztof