From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B3AEC54EE9 for ; Mon, 19 Sep 2022 14:33:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbiISOc7 (ORCPT ); Mon, 19 Sep 2022 10:32:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230114AbiISOcg (ORCPT ); Mon, 19 Sep 2022 10:32:36 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AECDF958D for ; Mon, 19 Sep 2022 07:32:31 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id r3-20020a05600c35c300b003b4b5f6c6bdso4695937wmq.2 for ; Mon, 19 Sep 2022 07:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=A9ZVitjkAEGpnZEnzG/yYMW8bMjYpZFzQstbESMk85k=; b=Hsc0/7dJ93g3C+RM6B0gh6s2C0QY2FmJ2P8mPyz5ZiV6KdI21qpn/nqwB3o55E9v/3 yr2IWNh6rundlOl3H7tKrAkLDuqs2TVP+MXlbsOcZTqBWlUK9tbf+2d94EKJXjA9AWPk 4R6zaAk8+PXOqmGdDUMp0HcFpeX8P8wI9Omm4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=A9ZVitjkAEGpnZEnzG/yYMW8bMjYpZFzQstbESMk85k=; b=kVIjM0+mJWHwtb02Q52/pWRVMwbiOSybafRq3/nwIjPK89hKKrcGQ71JFSAx/XPk8F l5XCsWfZ9ihky/oQ8t1xj//TQDX63mDeC7JKz6pgZvOU7a2YKLqgYgBlZjqRY9F0z8zd 9/qdEBPdMkpOzN0n2sPNrYGxRh75cjxmm4cFJJeBgXTjUkDWIF72dxa2fzoyHVoRXEaO AtCBHTDaTeHOFtzISFGo2cd8WCxvX2zJQpiYGZB2ICLImPTxNCfZCGfoGH5LWf1l2PtN Ni9i/I+7pMyNYkqznGHyLVugVWlV0P/z7BpuNpH/MajBV9RSsOanty0rvqt8PYoSE+k/ 2ipg== X-Gm-Message-State: ACrzQf2NR9FevxoYCFc2apKRIaNxN7adalWzyn2uo60BCG1qecbjVf7a 9GN/oOMi0ErtiCtGjskqRul+k5ZYZZruNA== X-Google-Smtp-Source: AMsMyM68+bWGmJaxNe7ptaLx1otoAMgV7X/EAQqBGtn/31ky1deDBYUNZ9a/l1yfeCEUFlWL/PfDQw== X-Received: by 2002:a05:600c:434c:b0:3b4:82fb:5f78 with SMTP id r12-20020a05600c434c00b003b482fb5f78mr12493510wme.157.1663597950298; Mon, 19 Sep 2022 07:32:30 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-56-12.cust.vodafonedsl.it. [188.217.56.12]) by smtp.gmail.com with ESMTPSA id p5-20020a5d4585000000b002206203ed3dsm13909632wrq.29.2022.09.19.07.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 07:32:29 -0700 (PDT) Date: Mon, 19 Sep 2022 16:32:27 +0200 From: Tommaso Merciai To: Rafael Mendonca Cc: Mauro Carvalho Chehab , Paul Kocialkowski , Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: i2c: ov5648: Free V4L2 fwnode data on unbind Message-ID: <20220919143227.GC3958@tom-ThinkPad-T14s-Gen-2i> References: <20220919023247.731106-1-rafaelmendsr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919023247.731106-1-rafaelmendsr@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Rafael, On Sun, Sep 18, 2022 at 11:32:46PM -0300, Rafael Mendonca wrote: > The V4L2 fwnode data structure doesn't get freed on unbind, which leads to > a memleak. > > Fixes: e43ccb0a045f ("media: i2c: Add support for the OV5648 image sensor") > Signed-off-by: Rafael Mendonca > --- > drivers/media/i2c/ov5648.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/ov5648.c b/drivers/media/i2c/ov5648.c > index dfcd33e9ee13..95850f06112b 100644 > --- a/drivers/media/i2c/ov5648.c > +++ b/drivers/media/i2c/ov5648.c > @@ -2598,6 +2598,8 @@ static int ov5648_remove(struct i2c_client *client) > mutex_destroy(&sensor->mutex); > media_entity_cleanup(&subdev->entity); > > + v4l2_fwnode_endpoint_free(&sensor->endpoint); > + > return 0; > } > > -- > 2.34.1 > Looks good to me. Reviewed-by: Tommaso Merciai Regards, Tommaso -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com