From: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
To: <linux-media@vger.kernel.org>
Cc: <alain.volmat@foss.st.com>, <hugues.fruchet@foss.st.com>,
<sylvain.petinot@foss.st.com>, <dave.stevenson@raspberrypi.com>,
<sakari.ailus@linux.intel.com>,
<laurent.pinchart@ideasonboard.com>,
<kieran.bingham@ideasonboard.com>, <nicolas@ndufresne.ca>,
<hverkuil@xs4all.nl>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Subject: [PATCH v7 0/5] media: Add ST VGXY61 camera sensor driver
Date: Tue, 11 Oct 2022 14:05:50 +0200 [thread overview]
Message-ID: <20221011120555.28889-1-benjamin.mugnier@foss.st.com> (raw)
Hi,
This series adds a driver for the ST VGXY61 camera sensor. This camera sensor is
using the i2c bus for control and the csi-2 bus for data.
These commits introduce the MEDIA_BUS_FMT_Y16_1X16 as a media bus format (1/5),
a standard control in V4L2 for the hdr mode (2/5), dt bindings (3/5), driver
specific documentation for hdr modes (4/5), and the driver (4/5).
Tested on DragonBoard 410c, Raspberry Pi 4, and Qualcomm Robotics RB5.
We discussed a bit about the 'st,strobe-gpios-polarity' in the previous patchset
version (thank you Sakari), but I'm unsure we reached a consensus on this. Feel
free to comment again on the subject. Help is very appreciated.
Thanks,
Benjamin
v6->v7
- Move Y16 format to correct placea bit in its file
- Fix st,strobe-gpios-polarity name not matching dt bindings and comment it
a bit better
- Add sensor specific driver doc
- Rename control V4L2_CID_HDR_MODE to V4L2_CID_HDR_SENSOR_MODE
- Miscelaneous styling fixes
- Rebase on master
v5->v6:
- Remove slave mode for now
- Comment mipi_margin
v4->v5:
- Fix kernel test robot errors
v3->v4:
- Standardize V4L2_CID_HDR_MODE
- Refactor to 80 characters limit
- Better types handling
- Various others
- Rebase on master
v2->v3:
- Fix errors in dt bindings
- Use alphabetical order where applicable
- Remove US_PER_MS macro
- Rename device specific macros
- Fix some control grabs not releasing
- Move user controls to public header and add documentation
- Rename set_framerate to set_framelength
- Rework i2c access
- Remove branchings that should never happen
- Rework pattern generator setting
- Update information on sensor rules of thumb
- Remove temperature control
- Remove suspend and resume
- Move mutex init to probe
- Move detect to probe
- Fix async_subdev_register order
- Support autosuspend
- Add init_cfg
- Fix controls not updating when sensor was off
- Various cleaning
- Rebase on master
v1->v2:
- Move temperature control to v4l2-controls.h as a standard control
- Reserve controls in v4l2-controls.h for HDR control
- Remove GPIO strobbing controls
- Remove references to unused controls in sensor struct
- Use v4l2_find_nearest_size
- Use V4L2_COLORSPACE_RAW instead of V4L2_COLORSPACE_SRGB
- Fill ycbcr_enc, quantization, and xfer_func in v4l2_mbus_framefmt
- Change gain from formula to a register RAW write
- Change temperature control value directly
- Remove clock-name and clock-lanes from device tree bindings
- Declare crop zones in mode_info structure
- Remove frame_interval functions and add hblank and vblank instead
- Update controls dependencies on change
- Fix first exposure rule of thumb being too restrictive
- Disable hflip and vflip controls while streaming
- Change RGB media bus code to Y as the sensor is monochrome
- Add Y16 format to v4l2 media bus formats
- Add get_selection API
- Fix timeout errors while disabling streaming on high framerates
- Support pm_runtime
- Rebase on master
Benjamin Mugnier (5):
media: v4l: Add 1X16 16-bit greyscale media bus code definition
media: v4l: ctrls: Add a control for HDR mode
media: dt-bindings: Add ST VGXY61 camera sensor binding
media: Documentation: Add ST VGXY61 driver documentation
media: i2c: Add driver for ST VGXY61 camera sensor
.../bindings/media/i2c/st,st-vgxy61.yaml | 113 +
.../userspace-api/media/drivers/st-vgxy61.rst | 23 +
.../media/v4l/ext-ctrls-camera.rst | 8 +
.../media/v4l/subdev-formats.rst | 37 +
MAINTAINERS | 10 +
drivers/media/i2c/Kconfig | 10 +
drivers/media/i2c/Makefile | 1 +
drivers/media/i2c/st-vgxy61.c | 1964 +++++++++++++++++
drivers/media/v4l2-core/v4l2-ctrls-defs.c | 2 +
include/uapi/linux/media-bus-format.h | 3 +-
include/uapi/linux/v4l2-controls.h | 2 +
11 files changed, 2172 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/media/i2c/st,st-vgxy61.yaml
create mode 100644 Documentation/userspace-api/media/drivers/st-vgxy61.rst
create mode 100644 drivers/media/i2c/st-vgxy61.c
--
2.25.1
next reply other threads:[~2022-10-11 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 12:05 Benjamin Mugnier [this message]
2022-10-11 12:16 ` [PATCH v7 1/5] media: v4l: Add 1X16 16-bit greyscale media bus code definition Benjamin Mugnier
2022-10-11 12:16 ` [PATCH v7 2/5] media: v4l: ctrls: Add a control for HDR mode Benjamin Mugnier
2022-11-08 9:50 ` [PATCH v7 1/5] media: v4l: Add 1X16 16-bit greyscale media bus code definition Paul Elder
2022-10-11 12:30 ` [PATCH v7 3/5] media: dt-bindings: Add ST VGXY61 camera sensor binding Benjamin Mugnier
2022-10-11 12:30 ` [PATCH v7 4/5] media: Documentation: Add ST VGXY61 driver documentation Benjamin Mugnier
2022-10-25 7:35 ` Sakari Ailus
2022-10-11 12:30 ` [PATCH v7 5/5] media: i2c: Add driver for ST VGXY61 camera sensor Benjamin Mugnier
-- strict thread matches above, loose matches on Subject: below --
2022-10-11 12:03 [PATCH v7 0/5] media: Add ST VGXY61 camera sensor driver Benjamin Mugnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221011120555.28889-1-benjamin.mugnier@foss.st.com \
--to=benjamin.mugnier@foss.st.com \
--cc=alain.volmat@foss.st.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=hugues.fruchet@foss.st.com \
--cc=hverkuil@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox